Does disabling "Auto-close issues with merged linked pull requests" also disable explicit Closes/Fixes/Resolves keywords #193412
Replies: 2 comments
-
|
💬 Your Product Feedback Has Been Submitted 🎉 Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users. Here's what you can expect moving forward ⏩
Where to look to see what's shipping 👀
What you can do in the meantime 💻
As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities. Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐ |
Beta Was this translation helpful? Give feedback.
-
|
This behaviour also surprised me. But I also recognize that a product manager or task manager might be want to overrule the explicit closing as well. I would propose to have this as a separate option -- expand the auto-close functionality to support keywords. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
🏷️ Discussion Type
Bug
💬 Feature/Topic Area
Issues
Body
I’m seeing this behavior:
This is surprising because I do not want all linked PRs to auto-close issues — that breaks workflows where one issue may have multiple PRs — but I would still expect an explicit keyword like Closes/Fixes/Resolves to close the issue.
This does not align with the docs: https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
That page says a PR can be linked to an issue using a supported keyword, and that when the PR is merged into the default branch, the linked issue is automatically closed.
In my case, the PR still appears to have a closing issue reference, so the keyword seems to be parsed, but the final close step is skipped.
Guidelines
Beta Was this translation helpful? Give feedback.
All reactions