MAINT Fix a few lgtm lints (pyodide#1602)

Author: Hood Chatham

packages/matplotlib/src/wasm_backend.py

@@ -274,7 +274,6 @@ def onmousedown(self, event):
         self.button_press_event(x, y, button, guiEvent=event)
 
     def onmouseenter(self, event):
-        return
         # When the mouse is over the figure, get keyboard focus
         self.get_element("rubberband").focus()
         self.enter_notify_event(guiEvent=event)

src/core/pyproxy.js

@@ -970,7 +970,7 @@ Module.PyProxyBufferMethods = {
           "Javascript has no native support for big endian buffers. " +
             "In this case, you can pass an explicit type argument. " +
             "For instance, `getBuffer('dataview')` will return a `DataView`" +
-            "which has native support for reading big endian data." +
+            "which has native support for reading big endian data. " +
             "Alternatively, toJs will automatically convert the buffer " +
             "to little endian."
         );

src/core/python2js_buffer.js

@@ -149,7 +149,7 @@ JS_FILE(python2js_buffer_init, () => {
     let byteLength = itemsize * n;
     // Make new memory of the appropriate size
     let buffer = new Uint8Array(byteLength);
-    for (i = 0; i < n; ++i) {
+    for (let i = 0; i < n; ++i) {
       let curptr = ptr + i * stride;
       if (suboffset >= 0) {
         curptr = HEAP32[curptr / 4] + suboffset;

src/js/pyodide.js

@@ -233,7 +233,7 @@ def temp(Module):
   // TODO: Should we have this?
   Module.globals = Module.wrapNamespace(Module.globals);
 
-  fixRecursionLimit(Module);
+  fixRecursionLimit();
   let pyodide = makePublicAPI();
   pyodide.globals = Module.globals;
   pyodide.pyodide_py = Module.pyodide_py;

src/py/pyodide/webloop.py

@@ -282,12 +282,6 @@ def default_exception_handler(self, context):
         if not message:
             message = "Unhandled exception in event loop"
 
-        exception = context.get("exception")
-        if exception is not None:
-            exc_info = (type(exception), exception, exception.__traceback__)
-        else:
-            exc_info = False
-
         if (
             "source_traceback" not in context
             and self._current_handle is not None

src/templates/console.html

@@ -93,7 +93,7 @@
         pyconsole.stdout_callback = s => term.echo(s, {newline : false});
         pyconsole.stderr_callback = s => {
             term.error(s.trimEnd());
-        }
+        };
         term.ready = Promise.resolve();
         pyodide._module.on_fatal = async (e) => {
           term.error("Pyodide has suffered a fatal error. Please report this to the Pyodide maintainers.");