Conversation
Contributor
|
Thank you @MartinM85, we'll try to review it ASAP! |
# Conflicts: # docs/src/config/sidebars.ts
martinlingstuyl
requested changes
Dec 11, 2023
martinlingstuyl
left a comment
martinlingstuyl
left a comment
Contributor
There was a problem hiding this comment.
Looks fine @MartinM85, just a couple of remarks. I'll merge it as soon as you've found the time to fix them.
martinlingstuyl
marked this pull request as draft
December 11, 2023 20:22
MartinM85
marked this pull request as ready for review
December 12, 2023 07:42
martinlingstuyl
approved these changes
Dec 13, 2023
martinlingstuyl
left a comment
martinlingstuyl
left a comment
Contributor
There was a problem hiding this comment.
Looks fine like this. I'll merge it soon!
Contributor
|
Merged manually, thank you! 🥳 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5615