gh-127629: Add ctypes to the Emscripten build#127683
gh-127629: Add ctypes to the Emscripten build#127683freakboy3742 merged 6 commits intopython:mainfrom
Conversation
freakboy3742
left a comment
freakboy3742
left a comment
There was a problem hiding this comment.
Functionally, this works fine; a couple of questions inline about documentation and gross structure.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again. Thanks @freakboy3742! |
|
Thanks for making the requested changes! @freakboy3742: please review the changes made to this pull request. |
freakboy3742
left a comment
freakboy3742
left a comment
There was a problem hiding this comment.
👍 Thanks for those fixes - this looks great!
Adds tooling to build libffi and add ctypes to the stdlib for Emscripten.
| export EM_PKG_CONFIG_PATH="$PKG_CONFIG_PATH" | ||
|
|
||
| # Specific variables for cross-compilation | ||
| export CHOST="wasm32-unknown-linux" # wasm32-unknown-emscripten |
There was a problem hiding this comment.
Why did this end up being wasm32-unknown-linux instead of wasm32-unknown-emscripten?
There was a problem hiding this comment.
Good question. Maybe I put it that way while debugging and didn't notice before merging.
3 participants
Uh oh!
There was an error while loading. Please reload this page.