gh-129948: Add `set()` to `multiprocessing.managers.SyncManager` by mmingyu · Pull Request #129949 · python/cpython

mmingyu · 2025-02-10T10:51:43Z

The SyncManager provides support for various data structures such as dict, list, and queue, but oddly, it does not support set. This inconsistency feels little bit weird.

This PR introduces support for set by defining SetProxy and registering it with SyncManager.

Issue: Add set() to multiprocessing.managers.SyncManager #129948

ghost · 2025-02-10T10:51:47Z

All commit authors signed the Contributor License Agreement.

bedevere-app · 2025-02-10T10:51:48Z

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app · 2025-02-10T10:54:17Z

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

bedevere-app · 2025-02-11T06:41:27Z

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

auvipy

may be some description regarding why adding this would be beneficiary is helpful to understand the reasoning

mmingyu · 2025-02-11T09:19:29Z

may be some description regarding why adding this would be beneficiary is helpful to understand the reasoning

Thanks for the advice!
Are you suggesting that I should make the PR description more detailed? I've updated the PR description

auvipy

yes it seems more clear now

picnixz

New features require a full-fleded What's New Entry (in Doc/whatsnew/3.14.rst in this case) as well as an updated documentation (likely in Doc/library/multiprocessing.rst). Please add them as well.

Lib/test/_test_multiprocessing.py

Misc/NEWS.d/next/Library/2025-02-11-06-42-17.gh-issue-129948.ZcugY9.rst

bedevere-app · 2025-02-11T10:07:23Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Lib/multiprocessing/managers.py

…_ return a set instead of a SetProxy

Lib/multiprocessing/managers.py

picnixz

Some final nits and I think we're good (but we'll need to wait for @gpshead's review because he's the mp's expert, I'm not).

Lib/multiprocessing/managers.py

Lib/test/_test_multiprocessing.py

picnixz · 2025-02-23T17:56:13Z

I've merged main into the branch because I think the CI has changed.

In addition, please avoid force-pushing in general. We squash-merge at the end, and force-pushing makes incremental reviews harder. TiA.

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Lib/test/_test_multiprocessing.py

Doc/library/multiprocessing.rst

picnixz · 2025-02-23T20:20:21Z

Thank you for the contribution @mmingyu and for the review @gpshead !

…rs for Python 3.14.0a5+ (python/cpython#129949)

python#129948: support multiprocessing.manager.set

bd5b81c

mmingyu requested a review from gpshead as a code owner February 10, 2025 10:51

bedevere-app bot added the awaiting review label Feb 10, 2025

bedevere-app bot mentioned this pull request Feb 10, 2025

Add set() to multiprocessing.managers.SyncManager #129948

Closed

fix lint

d762661

📜🤖 Added by blurb_it.

3514b42

mmingyu changed the title ~~gh-129948: Add set() Support to multiprocessing.managers.SyncManager~~ Feb 10, 2025

blurb-it bot and others added 3 commits February 11, 2025 06:36

📜🤖 Added by blurb_it.

e529f5f

remove first doc

f0f7d25

remove doc

41cb4a6

blurb-it bot and others added 4 commits February 11, 2025 06:42

📜🤖 Added by blurb_it.

4796816

fix lint

40c60cc

fix doc lint

5e0977f

doc: update comment

5c02940

auvipy reviewed Feb 11, 2025

View reviewed changes

auvipy approved these changes Feb 11, 2025

View reviewed changes

bedevere-app bot added awaiting core review and removed awaiting review labels Feb 11, 2025

picnixz previously requested changes Feb 11, 2025

View reviewed changes

Lib/test/_test_multiprocessing.py Outdated Show resolved Hide resolved

Misc/NEWS.d/next/Library/2025-02-11-06-42-17.gh-issue-129948.ZcugY9.rst Outdated Show resolved Hide resolved

bedevere-app bot added awaiting changes and removed awaiting core review labels Feb 11, 2025

picnixz reviewed Feb 11, 2025

View reviewed changes

Lib/multiprocessing/managers.py Outdated Show resolved Hide resolved

mmingyu added 2 commits February 11, 2025 22:10

Remove hard coding in MakeProxyType

3132d2a

test: Seperate test_set, Add test_set_contain_all_method

deb8b73

mmingyu added 2 commits February 23, 2025 09:21

Fix the bug where SetProxy's __ior__, __ixor__, __iand__, and __isub_…

3706c78

…_ return a set instead of a SetProxy

Fix missing __ge__, __gt__, __le__, and __lt__ methods in SetProxy

a259b39

mmingyu commented Feb 23, 2025

View reviewed changes

Lib/multiprocessing/managers.py Outdated Show resolved Hide resolved

Addressed code review comments

121b742

mmingyu force-pushed the feature/set-proxy branch from 6252328 to 121b742 Compare February 23, 2025 01:00

mmingyu added 2 commits February 23, 2025 10:16

Hardcode SetProxy methods

e8b449f

Grouping tests for issuperset and issubset

c3c3075

mmingyu requested a review from picnixz February 23, 2025 01:22

picnixz approved these changes Feb 23, 2025

View reviewed changes

Lib/multiprocessing/managers.py Outdated Show resolved Hide resolved

Lib/multiprocessing/managers.py Show resolved Hide resolved

Lib/test/_test_multiprocessing.py Show resolved Hide resolved

bedevere-app bot added awaiting merge and removed awaiting changes labels Feb 23, 2025

picnixz and others added 4 commits February 23, 2025 18:56

Merge branch 'main' into feature/set-proxy

3af48c3

Update Lib/test/_test_multiprocessing.py

13c18c7

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Update Lib/multiprocessing/managers.py

af37eae

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

Update Lib/multiprocessing/managers.py

a34e461

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>

gpshead approved these changes Feb 23, 2025

View reviewed changes

Lib/test/_test_multiprocessing.py Outdated Show resolved Hide resolved

Update Lib/test/_test_multiprocessing.py

df6330a

gpshead reviewed Feb 23, 2025

View reviewed changes

Doc/library/multiprocessing.rst Show resolved Hide resolved

Update Doc/library/multiprocessing.rst

9d13129

gpshead self-assigned this Feb 23, 2025

gpshead added the type-feature A feature request or enhancement label Feb 23, 2025

gpshead enabled auto-merge (squash) February 23, 2025 19:27

gpshead merged commit 9f81f82 into python:main Feb 23, 2025
41 checks passed

bedevere-app bot removed the awaiting merge label Feb 23, 2025

mmingyu added a commit to mmingyu/typeshed that referenced this pull request Feb 25, 2025

Add SetProxy and support for set operations in multiprocessing manage…

75e584a

…rs for Python 3.14.0a5+ (python/cpython#129949)

mmingyu mentioned this pull request Feb 25, 2025

Add SetProxy and support for set operations in multiprocessing.managers for Python 3.14.0a5+ python/typeshed#13535

Closed

This was referenced May 16, 2025

Add SetProxy and support for set operations in multiprocessing.managers for Python 3.14 python/typeshed#14076

Closed

Add SetProxy and support for set operations in multiprocessing.managers for Python 3.14 python/typeshed#14077

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

gh-129948: Add `set()` to `multiprocessing.managers.SyncManager`#129949

gh-129948: Add `set()` to `multiprocessing.managers.SyncManager`#129949
gpshead merged 40 commits intopython:mainfrom
mmingyu:feature/set-proxy

mmingyu commented Feb 10, 2025 •

edited

Loading

ghost commented Feb 10, 2025 •

edited by ghost

Loading

bedevere-app bot commented Feb 10, 2025

bedevere-app bot commented Feb 10, 2025

bedevere-app bot commented Feb 11, 2025

auvipy left a comment

mmingyu commented Feb 11, 2025

auvipy left a comment

picnixz left a comment

Uh oh!

Uh oh!

bedevere-app bot commented Feb 11, 2025

Uh oh!

Uh oh!

picnixz left a comment

Uh oh!

Uh oh!

Uh oh!

picnixz commented Feb 23, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

picnixz commented Feb 23, 2025

Labels

4 participants

Uh oh!

Conversation

mmingyu commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ghost commented Feb 10, 2025 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

bedevere-app bot commented Feb 10, 2025

bedevere-app bot commented Feb 10, 2025

bedevere-app bot commented Feb 11, 2025

auvipy left a comment

Choose a reason for hiding this comment

mmingyu commented Feb 11, 2025

auvipy left a comment

Choose a reason for hiding this comment

picnixz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bedevere-app bot commented Feb 11, 2025

Uh oh!

Uh oh!

picnixz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

picnixz commented Feb 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

picnixz commented Feb 23, 2025

Labels

4 participants

mmingyu commented Feb 10, 2025 •

edited

Loading

ghost commented Feb 10, 2025 •

edited by ghost

Loading

picnixz commented Feb 23, 2025 •

edited

Loading