Skip to content

Commit 48da888

Browse files
authored
Replace fields __all__ in modelview (mdn#75)
* Replace fields `__all__` in modelview except for one instance, and for that one, add "disclaimer". Also reverse order of using `__all__` so it is not the first presented.
1 parent 2770162 commit 48da888

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

‎catalog/views.py‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -131,14 +131,14 @@ def renew_book_librarian(request, pk):
131131

132132
class AuthorCreate(PermissionRequiredMixin, CreateView):
133133
model = Author
134-
fields = '__all__'
135-
initial = {'date_of_death': '05/01/2018'}
134+
fields = ['first_name', 'last_name', 'date_of_birth', 'date_of_death']
135+
initial = {'date_of_death': '11/06/2020'}
136136
permission_required = 'catalog.can_mark_returned'
137137

138138

139139
class AuthorUpdate(PermissionRequiredMixin, UpdateView):
140140
model = Author
141-
fields = ['first_name', 'last_name', 'date_of_birth', 'date_of_death']
141+
fields = '__all__' # Not recommended (potential security issue if more fields added)
142142
permission_required = 'catalog.can_mark_returned'
143143

144144

@@ -151,13 +151,13 @@ class AuthorDelete(PermissionRequiredMixin, DeleteView):
151151
# Classes created for the forms challenge
152152
class BookCreate(PermissionRequiredMixin, CreateView):
153153
model = Book
154-
fields = '__all__'
154+
fields = ['title', 'author', 'summary', 'isbn', 'genre', 'language']
155155
permission_required = 'catalog.can_mark_returned'
156156

157157

158158
class BookUpdate(PermissionRequiredMixin, UpdateView):
159159
model = Book
160-
fields = '__all__'
160+
fields = ['title', 'author', 'summary', 'isbn', 'genre', 'language']
161161
permission_required = 'catalog.can_mark_returned'
162162

163163

0 commit comments

Comments
 (0)