change type checker to using lodash

Author: spitliner

package-lock.json

@@ -18,7 +18,8 @@
   },
   "dependencies": {
     "@msgpack/msgpack": "2.8.0",
-    "component-emitter": "2.0.0"
+    "component-emitter": "2.0.0",
+    "lodash": "^4.17.21"
   },
   "scripts": {
     "build": "rimraf dist/* && pkgroll",
@@ -43,6 +44,7 @@
     "dist"
   ],
   "devDependencies": {
+    "@types/lodash": "^4.17.4",
     "@types/mocha": "^10.0.6",
     "mocha": "10.4.0",
     "nyc": "15.1.0",

package.json

@@ -2,9 +2,10 @@
 /* eslint-disable @typescript-eslint/no-unsafe-enum-comparison */
 import msgpack from '@msgpack/msgpack';
 import Emitter from 'component-emitter';
-import { isInteger, isObject, isString } from './type-checkers';
+import isString from 'lodash/isString';
 import { PacketType } from './packet-format';
 import validatePacketData from './validate-packet-data';
+import { objectIsInteger, isRecord } from './type-checkers';
 
 export class DecoderClass extends Emitter {
     options: msgpack.DecodeOptions = {};
@@ -28,11 +29,11 @@ const buildDecoder = (options: msgpack.DecodeOptions = {}): typeof DecoderClass
     }
 
     validatePacket(decoded: unknown) {
-        if (!isObject(decoded)) {
+        if (!isRecord(decoded)) {
             throw new Error('invalid packet');
         }
 
-        const isValidTypeField = isInteger(decoded.type)
+        const isValidTypeField = objectIsInteger(decoded.type)
                                 && decoded.type >= PacketType.CONNECT
                                 && decoded.type <= PacketType.CONNECT_ERROR;
 
@@ -48,7 +49,7 @@ const buildDecoder = (options: msgpack.DecodeOptions = {}): typeof DecoderClass
             throw new Error('invalid packet payload');
         }
 
-        if (undefined !== decoded.id && !isInteger(decoded.id)) {
+        if (undefined !== decoded.id && !objectIsInteger(decoded.id)) {
             throw new Error('invalid packet id');
         }
     }

src/decoder.ts

@@ -1,11 +1,9 @@
-export function isString(object: unknown) {
-    return 'string' === typeof object;
-}
+import isInteger from 'lodash/isInteger';
 
-export function isObject(object: unknown): object is Record<string, unknown> {
+export function isRecord(object: unknown): object is Record<string, unknown> {
     return null !== object && 'object' === typeof object && !Array.isArray(object);
 }
 
-export function isInteger(object: unknown): object is number {
-    return Number.isInteger(object);
+export function objectIsInteger(object: unknown): object is number {
+    return isInteger(object);
 }

src/type-checkers.ts

@@ -1,5 +1,6 @@
+import isObject from 'lodash/isObject';
+import isString from 'lodash/isString';
 import { PacketType } from './packet-format';
-import { isObject, isString } from './type-checkers';
 
 function validatePacketData(packet: Record<string, unknown>) {
     switch (packet.type) {

src/validate-packet-data.ts

@@ -36,7 +36,7 @@
     // "noResolve": true,                                /* Disallow 'import's, 'require's or '<reference>'s from expanding the number of files TypeScript should add to a project. */
     /* JavaScript Support */
     "allowJs": true,                                  /* Allow JavaScript files to be a part of your program. Use the 'checkJS' option to get errors from these files. */
-    // "checkJs": true,                                  /* Enable error reporting in type-checked JavaScript files. */
+    "checkJs": true,                                  /* Enable error reporting in type-checked JavaScript files. */
     // "maxNodeModuleJsDepth": 1,                        /* Specify the maximum folder depth used for checking JavaScript files from 'node_modules'. Only applicable with 'allowJs'. */
     /* Emit */
     "declaration": true,                              /* Generate .d.ts files from TypeScript and JavaScript files in your project. */