Fix typos, create builder functions, add prettierrc file

Author: Georgios Giatsidis

.prettierrc

@@ -0,0 +1,7 @@
+{
+    "printWidth": 120,
+    "useTabs": false,
+    "tabWidth": 4,
+    "semi": true,
+    "singleQuote": true
+}

index.js

@@ -1,9 +1,12 @@
-exports = {};
+const buildEncoder = require('./lib/encoder');
+const buildDecoder = require('./lib/decoder');
+const PacketType = require('./lib/packetType');
 
 exports.build = function (options = {}) {
     return {
         protocol: 5,
-        Encoder: new Encoder(options.encoder),
-        Decoder: new Decoder(options.decoder)
-    }
-}
+        Encoder: buildEncoder(options.encoder),
+        Decoder: buildDecoder(options.decoder),
+        PacketType: PacketType,
+    };
+};

lib/decoder.js

@@ -1,59 +1,44 @@
 const msgpack = require('@msgpack/msgpack');
-const _ = require('lodash');
 const Emitter = require('component-emitter');
-const PacketType = (exports.PacketType = {
-    CONNECT: 0,
-    DISCONNECT: 1,
-    EVENT: 2,
-    ACK: 3,
-    CONNECT_ERROR: 4,
-});
-
-class Decoder {
-
-    constructor(options) {
-        this.options = options;
-        this.emitter = new Emitter();
-    }
-
-    add (obj) {
-        let decoded = msgpack.decode(obj, this.options);
-        this.checkPacket(decoded);
-        this.emitter.emit('decoded', decoded);
-    }
+const _ = require('lodash');
+const PacketType = require('./packetType');
+const { isDataValid } = require('./helpers');
 
-    isDataValid(decoded) {
-        switch (decoded.type) {
-            case PacketType.CONNECT:
-                return decoded.data === undefined || _.isObject(decoded.data);
-            case PacketType.DISCONNECT:
-                return decoded.data === undefined;
-            case PacketType.CONNECT_ERROR:
-                return _.isString(decoded.data) || _.isObject(decoded.data);
-            default:
-                return _.isArray(decoded.data);
+const buildDecoder = (options = {}) => {
+    return class Decoder extends Emitter {
+        constructor() {
+            super();
+            this.options = options;
         }
-    }
 
-    checkPacket = function (decoded) {
-        var isTypeValid =
-            _.isInteger(decoded.type) && decoded.type >= PacketType.CONNECT && decoded.type <= PacketType.CONNECT_ERROR;
-        if (!isTypeValid) {
-            throw new Error('invalid packet type');
-        }
-        if (!_.isString(decoded.nsp)) {
-            throw new Error('invalid namespace');
+        add(obj) {
+            let decoded = msgpack.decode(obj, this.options);
+            this.checkPacket(decoded);
+            this.emit('decoded', decoded);
         }
-        if (!isDataValid(decoded)) {
-            throw new Error('invalid payload');
-        }
-        var isAckValid = decoded.id === undefined || _.isInteger(decoded.id);
-        if (!isAckValid) {
-            throw new Error('invalid packet id');
+
+        checkPacket(decoded) {
+            var isTypeValid =
+                _.isInteger(decoded.type) &&
+                decoded.type >= PacketType.CONNECT &&
+                decoded.type <= PacketType.CONNECT_ERROR;
+            if (!isTypeValid) {
+                throw new Error('invalid packet type');
+            }
+            if (!_.isString(decoded.nsp)) {
+                throw new Error('invalid namespace');
+            }
+            if (!isDataValid(decoded)) {
+                throw new Error('invalid payload');
+            }
+            var isAckValid = decoded.id === undefined || _.isInteger(decoded.id);
+            if (!isAckValid) {
+                throw new Error('invalid packet id');
+            }
         }
-    }
 
-    destroy () {};
-}
+        destroy() {}
+    };
+};
 
-exports = Decoder;
+module.exports = buildDecoder;

lib/encoder.js

@@ -1,14 +1,15 @@
 const msgpack = require('@msgpack/msgpack');
 
-class Encoder {
-
-    constructor(options = {}) {
-        this.soptions = options;
-    }
-
-    encode () {
-        return turn [msgpack.encode(packet, options)];
-    }
-}
-
-exports = Encoder;
+const buildEncoder = (options = {}) => {
+    return class Encoder {
+        constructor() {
+            this.options = options;
+        }
+
+        encode(packet) {
+            return [msgpack.encode(packet), options];
+        }
+    };
+};
+
+module.exports = buildEncoder;

lib/helpers.js

@@ -0,0 +1,19 @@
+const PacketType = require('./packetType');
+const _ = require('lodash');
+
+function isDataValid(decoded) {
+    switch (decoded.type) {
+        case PacketType.CONNECT:
+            return decoded.data === undefined || _.isObject(decoded.data);
+        case PacketType.DISCONNECT:
+            return decoded.data === undefined;
+        case PacketType.CONNECT_ERROR:
+            return _.isString(decoded.data) || _.isObject(decoded.data);
+        default:
+            return Array.isArray(decoded.data);
+    }
+}
+
+module.exports = {
+    isDataValid,
+};

lib/packetType.js

@@ -0,0 +1,9 @@
+const PacketType = {
+    CONNECT: 0,
+    DISCONNECT: 1,
+    EVENT: 2,
+    ACK: 3,
+    CONNECT_ERROR: 4,
+};
+
+module.exports = PacketType;