Add ability to sort by frontmatter parameters #3022
Merged
+71
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bep
requested changes
Feb 9, 2017
Member
bep
left a comment
bep
left a comment
There was a problem hiding this comment.
This is useful, and if you can address my comments and add a line or two in the docs, I will merge.
Contributor
Author
|
This should address the remarks you had earlier, @bep. Let me know how else I can help. |
bep
approved these changes
Feb 10, 2017
Member
bep
left a comment
bep
left a comment
There was a problem hiding this comment.
Now it looks right. A line in the doc and this is good o go.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to sort by the value of a specified frontmatter key, including anything that would otherwise be available in
.Params. Comparisons (and thus the resulting sorting) are done on a string basis, so, for example,xyz123comes before and not afterxyz23.This is useful for general-purpose sorting for which
weightis either not sufficient or where it duplicates information that's already present in the frontmatter. See discussions here.If the committers are happy with this implementation, I'll also add the correspondingly necessary documentation for this feature.