Added Authentication to RedisCache (botman#446)

Author: flavioheleno

.travis.yml

@@ -10,6 +10,7 @@ php:
 before_script:
   - travis_retry composer self-update --preview
   - travis_retry composer install --prefer-dist --no-interaction
+  - sudo redis-server /etc/redis/redis.conf --port 6380 --requirepass 'secret'
 
 script:
   - vendor/bin/phpunit --coverage-clover=coverage.xml
@@ -19,4 +20,4 @@ before_install:
   - echo "extension = redis.so" >> ~/.phpenv/versions/$(phpenv version-name)/etc/php.ini
 
 after_success:
-  - codecov
+  - codecov

src/Cache/RedisCache.php

@@ -17,19 +17,22 @@ class RedisCache implements CacheInterface
     private $redis;
     private $host;
     private $port;
+    private $auth;
 
     /**
      * RedisCache constructor.
      * @param $host
      * @param $port
+     * @param $auth
      */
-    public function __construct($host = '127.0.0.1', $port = 6379)
+    public function __construct($host = '127.0.0.1', $port = 6379, $auth = null)
     {
         if (! class_exists('Redis')) {
             throw new RuntimeException('phpredis extension is required for RedisCache');
         }
         $this->host = $host;
         $this->port = $port;
+        $this->auth = $auth;
         $this->connect();
     }
 
@@ -107,6 +110,10 @@ private function connect()
     {
         $this->redis = new Redis();
         $this->redis->connect($this->host, $this->port);
+        if ($this->auth !== null) {
+            $this->redis->auth($this->auth);
+        }
+
         if (function_exists('igbinary_serialize') && defined('Redis::SERIALIZER_IGBINARY')) {
             $this->redis->setOption(Redis::OPT_SERIALIZER, Redis::SERIALIZER_IGBINARY);
         } else {

tests/Cache/RedisCacheTest.php

@@ -3,6 +3,7 @@
 namespace BotMan\BotMan\Tests;
 
 use Redis;
+use RedisException;
 use PHPUnit_Framework_TestCase;
 use BotMan\BotMan\Cache\ArrayCache;
 use BotMan\BotMan\Cache\RedisCache;
@@ -21,10 +22,34 @@ protected function setUp()
 
     public function tearDown()
     {
+        $script = sprintf("for i, name in ipairs(redis.call('KEYS', '%s*')) do redis.call('DEL', name); end", RedisCache::KEY_PREFIX);
+
         $redis = new Redis();
         $redis->connect('127.0.0.1');
-        $script = sprintf("for i, name in ipairs(redis.call('KEYS', '%s*')) do redis.call('DEL', name); end", RedisCache::KEY_PREFIX);
         $redis->eval($script);
+        $redis->close();
+
+        $redis = new Redis();
+        $redis->connect('127.0.0.1', 6380);
+        $redis->auth('secret');
+        $redis->eval($script);
+        $redis->close();
+    }
+
+    /** @test */
+    public function valid_auth()
+    {
+        $cache = new RedisCache('127.0.0.1', 6380, 'secret');
+        $cache->put('foo', 'bar', 1);
+        static::assertTrue($cache->has('foo'));
+    }
+
+    /** @test */
+    public function invalid_auth()
+    {
+        static::setExpectedException(RedisException::class);
+        $cache = new RedisCache('127.0.0.1', 6380, 'invalid');
+        $cache->put('foo', 'bar', 1);
     }
 
     /** @test */