Add HolyC support #750
Merged
Add HolyC support #750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
alecthomas
reviewed
Feb 15, 2023
|
Fixed that |
|
No worries, it happens. If you could add a test input that would be great. Check the testdata/README.md file for instructions. |
|
There is also at least one regex issue which is in the CI logs. You can test this locally with |
|
Oof sorry I didn't see that. |
Alright, apologies @alecthomas, I've never really worked with Go before prior to this, so I had no idea I could test it. Anyways it's fixed. |
|
Lovely, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to add HolyC support by cross referencing GitHub's Linguist HolyC implementation against it's C implementation to see how the syntax is different. Then copied the C file on Chroma and applied those changes. This hopefully should work.