Skip to content

bugfix: correct error type parsing for restJson services #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 15, 2023
Merged

bugfix: correct error type parsing for restJson services #2012

merged 4 commits into from
Feb 15, 2023

Conversation

lucix-aws
Copy link
Contributor

Adjust restJson error parsing to deduce error type from the following locations in order:

  • X-Amzn-ErrorType header
  • code field of json body
  • __type field of json body

Fixes #1910
@lucix-aws lucix-aws requested a review from a team as a code owner February 3, 2023 20:02
@isaiahvita
Copy link
Contributor

isaiahvita commented Feb 6, 2023 •
edited
Loading

i just realized this fix is also a break-fix right?
if so, we should prob also add a changelog announcement. which just means creating another changelog file with type announcement.
you can see what the announcement changelog looks like here in the release for 2022-11-11
https://github.com/aws/aws-sdk-go-v2/blob/main/CHANGELOG.md
@lucix-aws lucix-aws mentioned this pull request Feb 13, 2023
Closed
@isaiahvita
Copy link
Contributor

LGTM: changelog for announcement
@lucix-aws lucix-aws merged commit 1f9c50e into main Feb 15, 2023
@lucix-aws lucix-aws deleted the fix-restjson-errorcode branch February 15, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@lucix-aws @isaiahvita @aajtodd