Skip to content

fix: reorder exports to place types first - #1261

Merged
straker merged 1 commit into
dequelabs:developfrom
JustasMonkev:fix/export-list-order
Jan 6, 2026
Merged

fix: reorder exports to place types first#1261
straker merged 1 commit into
dequelabs:developfrom
JustasMonkev:fix/export-list-order

Conversation

@JustasMonkev

@JustasMonkev JustasMonkev commented Dec 21, 2025 •
edited by straker
Loading

Copy link
Copy Markdown
Contributor

Move the "types" condition to the first position in package.json
exports field to align with Node.js conditional exports standards.
This ensures TypeScript properly resolves type definitions.

Closes: #1243
@JustasMonkev
JustasMonkev requested a review from a team as a code owner December 21, 2025 10:38
@CLAassistant

CLAassistant commented Dec 21, 2025 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.
straker
straker approved these changes Jan 6, 2026
View reviewed changes

@straker straker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes.
Garbee
Garbee approved these changes Jan 6, 2026
View reviewed changes

@Garbee Garbee left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ordering is correct per Node docs.

Thank you for putting the time into this.
@straker

straker commented Jan 6, 2026

Copy link
Copy Markdown
Contributor

Approved for security.
@straker
straker merged commit 40d22e3 into dequelabs:develop Jan 6, 2026
31 of 34 checks passed
@github-actions github-actions Bot mentioned this pull request Jan 9, 2026
Merged
straker added a commit that referenced this pull request Jan 12, 2026
@straker
chore: RC v4.11.1 (#1272)
9a07fd7 
##
[4.11.1](v4.11.0...v4.11.1)
(2026-01-09)


### Bug Fixes

* reorder exports to place types first
([#1261](#1261))
([40d22e3](40d22e3)),
closes [#1243](#1243)
* Update axe-core to v4.11.1
([#1271](#1271))
([77f577e](77f577e))
@Amandeque Amandeque mentioned this pull request Feb 3, 2026
Merged
@campaigner-prod campaigner-prod Bot mentioned this pull request Apr 23, 2026
Closed
4 tasks
@YusukeHirao YusukeHirao mentioned this pull request Jun 17, 2026
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@JustasMonkev @CLAassistant @straker @Garbee