refactor(locale): normalize phone_number data - #3518
Merged
Merged
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3518 +/- ##
==========================================
- Coverage 98.84% 98.78% -0.07%
==========================================
Files 914 914
Lines 3215 3215
Branches 574 574
==========================================
- Hits 3178 3176 -2
- Misses 33 35 +2
Partials 4 4 🚀 New features to boost your workflow:
|
ejcheng
previously approved these changes
May 25, 2025
Member
|
This PR needs a rebase. |
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ST-DDT
marked this pull request as ready for review
June 23, 2026 18:19
ST-DDT
approved these changes
Jun 23, 2026
Shinigami92
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-on to #2265.
Normalize the entries in the
phone_numbermodule definitions - in all locales. No entries have been removed. The changes are sorting only.How to verify
Checkout the branch:
The branch contains two commits. One that changes the script to include the internet module being part of the normalization and one that actually updates the files.
By restoring files before the normalization happened and running it yourself, you should see the same state as this PR provides:
You should end up with no changes in your work-tree.