Skip to content

refactor(locale): normalize phone_number data - #3518

Merged
ST-DDT merged 3 commits into
nextfrom
refactor/normalize-phone-number-data
Jun 24, 2026
Merged

ST-DDT merged 3 commits into
nextfrom
refactor/normalize-phone-number-data

Conversation

@xDivisionByZerox

Copy link
Copy Markdown
Member

Description

Follow-on to #2265.

Normalize the entries in the phone_number module definitions - in all locales. No entries have been removed. The changes are sorting only.

How to verify

Checkout the branch:

git switch refactor/normalize-phone-number-data

The branch contains two commits. One that changes the script to include the internet module being part of the normalization and one that actually updates the files.
By restoring files before the normalization happened and running it yourself, you should see the same state as this PR provides:

# undo the commit that ran the locale data generation
git checkout HEAD~1 . 

# since git checkout changes are always stages, they need to be brought to the work-tree
git restore --staged .

# run neccessary scripts
pnpm run generate:locales && pnpm run test:update-snapshots

You should end up with no changes in your work-tree.

@xDivisionByZerox
xDivisionByZerox requested a review from a team May 22, 2025 16:07
@xDivisionByZerox xDivisionByZerox self-assigned this May 22, 2025
@xDivisionByZerox
xDivisionByZerox requested a review from a team as a code owner May 22, 2025 16:07
@xDivisionByZerox xDivisionByZerox added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs c: locale Permutes locale definitions m: phone Something is referring to the phone module labels May 22, 2025
@netlify

netlify Bot commented May 22, 2025 •

Copy link
Copy Markdown

✅ Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit c9d6b7b
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/682f4be1e9d95d000816863c
😎 Deploy Preview https://deploy-preview-3518.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented May 22, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.78%. Comparing base (1107eab) to head (ce062c1).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3518      +/-   ##
==========================================
- Coverage   98.84%   98.78%   -0.07%     
==========================================
  Files         914      914              
  Lines        3215     3215              
  Branches      574      574              
==========================================
- Hits         3178     3176       -2     
- Misses         33       35       +2     
  Partials        4        4              

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Comment thread src/locales/fr_BE/phone_number/format/human.ts
Comment thread src/locales/sv/phone_number/format/human.ts
ejcheng
ejcheng previously approved these changes May 25, 2025
@ST-DDT

ST-DDT commented Apr 8, 2026

Copy link
Copy Markdown
Member

This PR needs a rebase.

@ST-DDT
ST-DDT marked this pull request as draft April 8, 2026 15:44
@ST-DDT ST-DDT added the needs rebase There is a merge conflict label Apr 8, 2026
@ST-DDT ST-DDT added this to the v10.x milestone Jun 22, 2026
@netlify

netlify Bot commented Jun 23, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit ce062c1
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/6a3acca8c7c22400087517b3
😎 Deploy Preview https://deploy-preview-3518.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@ST-DDT ST-DDT removed the needs rebase There is a merge conflict label Jun 23, 2026
@ST-DDT
ST-DDT marked this pull request as ready for review June 23, 2026 18:19
@ST-DDT
ST-DDT added this pull request to the merge queue Jun 24, 2026
Merged via the queue into next with commit 9a1cb7d Jun 24, 2026
37 of 38 checks passed
@ST-DDT
ST-DDT deleted the refactor/normalize-phone-number-data branch June 24, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: locale Permutes locale definitions c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: phone Something is referring to the phone module p: 1-normal Nothing urgent

4 participants