feat(locale): better organize first_name by gender for en - #3924
Merged
Merged
Conversation
in faker-js#3266 person definitions were newly organized into male, female and generic. However locales like en which had name lists largely not split by gender ended up with very long generic lists. In preparation for faker-js#3694 this attempts to fix that, by moving names to the most appropriate category. I used Genderize.io to help reorganize the list. No names are added or removed, only moved between lists. ``` - Total names: 3186 ## Moves between arrays - female -> generic: 2 - generic -> female: 1092 - generic -> male: 932 - male -> generic: 14 ## Sample moves - Alexis: female -> generic (female, p=0.62, n=188108) - Ollie: female -> generic (male, p=0.62, n=9255) - Aubrey: male -> generic (female, p=0.68, n=9750) - Carroll: male -> generic (male, p=0.68, n=1044) - Cary: male -> generic (male, p=0.71, n=6241) - Dallas: male -> generic (male, p=0.84, n=5599) - Frankie: male -> generic (male, p=0.82, n=22010) - Ira: male -> generic (male, p=0.83, n=19863) - Jordan: male -> generic (male, p=0.79, n=149418) - Loren: male -> generic (male, p=0.63, n=15813) - Merle: male -> generic (female, p=0.5, n=4545) - Sammy: male -> generic (male, p=0.74, n=38317) - Sidney: male -> generic (male, p=0.66, n=13699) - Taylor: male -> generic (female, p=0.67, n=44655) - Tommie: male -> generic (male, p=0.67, n=2711) - Van: male -> generic (male, p=0.72, n=22067) - Aaliyah: generic -> female (female, p=1, n=10863) - Abagail: generic -> female (female, p=1, n=611) - Abbey: generic -> female (female, p=0.99, n=21338) - Abbie: generic -> female (female, p=1, n=24753) - Abbigail: generic -> female (female, p=1, n=1372) - Abby: generic -> female (female, p=1, n=77730) - Abdiel: generic -> male (male, p=1, n=11395) - Abdul: generic -> male (male, p=1, n=521972) - Abdullah: generic -> male (male, p=1, n=388337) ```
✅ Deploy Preview for fakerjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #3924 +/- ##
==========================================
- Coverage 98.84% 98.78% -0.07%
==========================================
Files 923 923
Lines 3216 3216
Branches 583 583
==========================================
- Hits 3179 3177 -2
- Misses 33 35 +2
Partials 4 4 🚀 New features to boost your workflow:
|
ST-DDT
approved these changes
Jun 29, 2026
Shinigami92
approved these changes
Jun 29, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in #3266 person definitions were newly organized into male, female and generic. However locales like en which had name lists largely not split by gender ended up with very long generic lists. In preparation for #3694 this attempts to fix that, by moving names to the most appropriate category. I used Genderize.io to help reorganize the list. No names are added or removed, only moved between lists.