Skip to content

feat(locale): better organize first_name by gender for en - #3924

Merged
ST-DDT merged 1 commit into
faker-js:nextfrom
matthewmayer:better-en-name-genders
Jun 30, 2026
Merged

ST-DDT merged 1 commit into
faker-js:nextfrom
matthewmayer:better-en-name-genders

Conversation

@matthewmayer

Copy link
Copy Markdown
Contributor

in #3266 person definitions were newly organized into male, female and generic. However locales like en which had name lists largely not split by gender ended up with very long generic lists. In preparation for #3694 this attempts to fix that, by moving names to the most appropriate category. I used Genderize.io to help reorganize the list. No names are added or removed, only moved between lists.

- Total names: 3186

## Moves between arrays

- female -> generic: 2
- generic -> female: 1092
- generic -> male: 932
- male -> generic: 14

## Sample moves

- Alexis: female -> generic (female, p=0.62, n=188108)
- Ollie: female -> generic (male, p=0.62, n=9255)
- Aubrey: male -> generic (female, p=0.68, n=9750)
- Carroll: male -> generic (male, p=0.68, n=1044)
- Cary: male -> generic (male, p=0.71, n=6241)
- Dallas: male -> generic (male, p=0.84, n=5599)
- Frankie: male -> generic (male, p=0.82, n=22010)
- Ira: male -> generic (male, p=0.83, n=19863)
- Jordan: male -> generic (male, p=0.79, n=149418)
- Loren: male -> generic (male, p=0.63, n=15813)
- Merle: male -> generic (female, p=0.5, n=4545)
- Sammy: male -> generic (male, p=0.74, n=38317)
- Sidney: male -> generic (male, p=0.66, n=13699)
- Taylor: male -> generic (female, p=0.67, n=44655)
- Tommie: male -> generic (male, p=0.67, n=2711)
- Van: male -> generic (male, p=0.72, n=22067)
- Aaliyah: generic -> female (female, p=1, n=10863)
- Abagail: generic -> female (female, p=1, n=611)
- Abbey: generic -> female (female, p=0.99, n=21338)
- Abbie: generic -> female (female, p=1, n=24753)
- Abbigail: generic -> female (female, p=1, n=1372)
- Abby: generic -> female (female, p=1, n=77730)
- Abdiel: generic -> male (male, p=1, n=11395)
- Abdul: generic -> male (male, p=1, n=521972)
- Abdullah: generic -> male (male, p=1, n=388337)
in faker-js#3266 person definitions were newly organized into male, female and generic. However locales like en which had name lists largely not split by gender ended up with very long generic lists. In preparation for faker-js#3694 this attempts to fix that, by moving names to the most appropriate category. I used Genderize.io to help reorganize the list. No names are added or removed, only moved between lists.

```
- Total names: 3186

## Moves between arrays

- female -> generic: 2
- generic -> female: 1092
- generic -> male: 932
- male -> generic: 14

## Sample moves

- Alexis: female -> generic (female, p=0.62, n=188108)
- Ollie: female -> generic (male, p=0.62, n=9255)
- Aubrey: male -> generic (female, p=0.68, n=9750)
- Carroll: male -> generic (male, p=0.68, n=1044)
- Cary: male -> generic (male, p=0.71, n=6241)
- Dallas: male -> generic (male, p=0.84, n=5599)
- Frankie: male -> generic (male, p=0.82, n=22010)
- Ira: male -> generic (male, p=0.83, n=19863)
- Jordan: male -> generic (male, p=0.79, n=149418)
- Loren: male -> generic (male, p=0.63, n=15813)
- Merle: male -> generic (female, p=0.5, n=4545)
- Sammy: male -> generic (male, p=0.74, n=38317)
- Sidney: male -> generic (male, p=0.66, n=13699)
- Taylor: male -> generic (female, p=0.67, n=44655)
- Tommie: male -> generic (male, p=0.67, n=2711)
- Van: male -> generic (male, p=0.72, n=22067)
- Aaliyah: generic -> female (female, p=1, n=10863)
- Abagail: generic -> female (female, p=1, n=611)
- Abbey: generic -> female (female, p=0.99, n=21338)
- Abbie: generic -> female (female, p=1, n=24753)
- Abbigail: generic -> female (female, p=1, n=1372)
- Abby: generic -> female (female, p=1, n=77730)
- Abdiel: generic -> male (male, p=1, n=11395)
- Abdul: generic -> male (male, p=1, n=521972)
- Abdullah: generic -> male (male, p=1, n=388337)
```
@matthewmayer
matthewmayer requested a review from a team as a code owner June 29, 2026 17:53
@netlify

netlify Bot commented Jun 29, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 68043c1
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/6a42b0febf861500085d92c6
😎 Deploy Preview https://deploy-preview-3924.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.78%. Comparing base (acd5fda) to head (68043c1).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3924      +/-   ##
==========================================
- Coverage   98.84%   98.78%   -0.07%     
==========================================
  Files         923      923              
  Lines        3216     3216              
  Branches      583      583              
==========================================
- Hits         3179     3177       -2     
- Misses         33       35       +2     
  Partials        4        4              

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: person Something is referring to the person module labels Jun 29, 2026
@ST-DDT ST-DDT added this to the v10.x milestone Jun 29, 2026
@ST-DDT
ST-DDT added this pull request to the merge queue Jun 30, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 30, 2026
@ST-DDT
ST-DDT added this pull request to the merge queue Jun 30, 2026
Merged via the queue into faker-js:next with commit 119386b Jun 30, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: locale Permutes locale definitions m: person Something is referring to the person module p: 1-normal Nothing urgent

3 participants