Skip to content

Conversation

@mbg
Copy link
Member

@mbg mbg commented Sep 26, 2025

Slimmed down #3157

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.
@mbg mbg requested a review from henrymercer September 26, 2025 16:48
@mbg mbg self-assigned this Sep 26, 2025
@mbg mbg requested a review from a team as a code owner September 26, 2025 16:48
Copilot AI review requested due to automatic review settings September 26, 2025 16:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where the upload-sarif action was not uploading non-.sarif files for CodeScanning analysis. The fix modifies the file filtering logic to allow CodeScanning analysis to upload files that don't match the default SARIF predicate.

  • Updates the conditional logic in findAndUpload to handle non-SARIF files for CodeScanning
  • Adds specific handling for CodeScanning analysis kind when the file doesn't match standard SARIF extensions

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/upload-sarif-action.ts Updates TypeScript source to fix file filtering logic for CodeScanning analysis
lib/upload-sarif-action.js Contains the compiled JavaScript equivalent of the TypeScript changes
henrymercer
henrymercer previously approved these changes Sep 26, 2025
@henrymercer
Copy link
Contributor

Add a changelog note?

@mbg mbg enabled auto-merge September 26, 2025 16:53
@mbg mbg merged commit 0a67bd4 into main Sep 26, 2025
233 checks passed
@mbg mbg deleted the mbg/fix/upload-sarif branch September 26, 2025 17:06
@github-actions github-actions bot mentioned this pull request Sep 26, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants