Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: go1.24.12
Choose a base ref
...
head repository: golang/go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: go1.24.13
Choose a head ref
  • 9 commits
  • 19 files changed
  • 5 contributors

Commits on Jan 28, 2026

  1. [release-branch.go1.24] cmd/go: remove user-content from doc strings …

    …in cgo ASTs.
    
    Thank you to RyotaK (https://ryotak.net) of GMO Flatt Security Inc. for reporting this issue.
    
    Updates #76697
    Fixes #77128
    Fixes CVE-2025-61732
    
    Change-Id: Ie2a96b79a813e362cbf8e6cb0e3c2d0c022bcb29
    Reviewed-on: https://go-review.googlesource.com/c/go/+/740001
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: Roland Shoemaker <roland@golang.org>
    thatnealpatel authored and gopherbot committed Jan 28, 2026
    Configuration menu
    Copy the full SHA
    14d0bb3 View commit details
    Browse the repository at this point in the history
  2. [release-branch.go1.24] crypto/x509: fix single label excluded name c…

    …onstraints handling
    
    Only strip labels when both the domain and constraint have more than one
    label.
    
    Fixes #76935
    Fixes #77322
    
    Change-Id: I1144c9f03cbfc3b858af153a839b193bb934618d
    Reviewed-on: https://go-review.googlesource.com/c/go/+/739420
    Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
    Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Damien Neil <dneil@google.com>
    rolandshoemaker authored and gopherbot committed Jan 28, 2026
    Configuration menu
    Copy the full SHA
    2c4733c View commit details
    Browse the repository at this point in the history
  3. [release-branch.go1.24] cmd/go: update VCS commands to use safer flag…

    …/argument syntax
    
    In various situations, the toolchain invokes VCS commands. Some of these
    commands take arbitrary input, either provided by users or fetched from
    external sources. To prevent potential command injection vulnerabilities
    or misinterpretation of arguments as flags, this change updates the VCS
    commands to use various techniques to separate flags from positional
    arguments, and to directly associate flags with their values.
    
    Additionally, we update the environment variable for Mercurial to use
    `HGPLAIN=+strictflags`, which is the more explicit way to disable user
    configurations (intended or otherwise) that might interfere with command
    execution.
    
    We also now disallow version strings from being prefixed with '-' or
    '/', as doing so opens us up to making the same mistake again in the
    future. As far as we know there are currently ~0 public modules affected
    by this.
    
    While I was working on cmd/go/internal/vcs, I also noticed that a
    significant portion of the commands being implemented were dead code.
    In order to reduce the maintenance burden and surface area for potential
    issues, I removed the dead code for unused commands.
    
    We should probably follow up with a more structured change to make it
    harder to accidentally re-introduce these issues in the future, but for
    now this addresses the issue at hand.
    
    Thanks to splitline (@splitline) from DEVCORE Research Team for
    reporting this issue.
    
    Fixes CVE-2025-68119
    Updates #77099
    Fixes #77103
    
    Change-Id: I9d9f4ee05b95be49fe14edf71a1b8e6c0784378e
    Reviewed-on: https://go-internal-review.googlesource.com/c/go/+/3260
    Reviewed-by: Damien Neil <dneil@google.com>
    Reviewed-by: Nicholas Husin <husin@google.com>
    Reviewed-on: https://go-review.googlesource.com/c/go/+/736710
    Auto-Submit: Michael Pratt <mpratt@google.com>
    Reviewed-by: Junyang Shao <shaojunyang@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    (cherry picked from commit 94a1296)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/739421
    Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
    rolandshoemaker authored and gopherbot committed Jan 28, 2026
    Configuration menu
    Copy the full SHA
    73fe85f View commit details
    Browse the repository at this point in the history
  4. [release-branch.go1.24] Revert "crypto/tls: don't copy auto-rotated s…

    …ession ticket keys in Config.Clone"
    
    This reverts CL 736709 (commit bba2471).
    
    Updates #77113
    Updates #77355
    Updates CVE-2025-68121
    
    Change-Id: I0261cb75e9adf9d0ac9890dc91ae8476b8988ba0
    Reviewed-on: https://go-review.googlesource.com/c/go/+/739320
    Reviewed-by: Coia Prant <coiaprant@gmail.com>
    Reviewed-by: Filippo Valsorda <filippo@golang.org>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-on: https://go-review.googlesource.com/c/go/+/740060
    Reviewed-by: Damien Neil <dneil@google.com>
    Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: Nicholas Husin <nsh@golang.org>
    Reviewed-by: Nicholas Husin <husin@google.com>
    rolandshoemaker authored and gopherbot committed Jan 28, 2026
    Configuration menu
    Copy the full SHA
    b2abaab View commit details
    Browse the repository at this point in the history
  5. [release-branch.go1.24] crypto/tls: add verifiedChains expiration che…

    …cking during resumption
    
    When resuming a session, check that the verifiedChains contain at least
    one chain that is still valid at the time of resumption. If not, trigger
    a new handshake.
    
    Updates #77113
    Updates #77355
    Updates CVE-2025-68121
    
    Change-Id: I14f585c43da17802513cbdd5b10c552d7a38b34e
    Reviewed-on: https://go-review.googlesource.com/c/go/+/739321
    Reviewed-by: Coia Prant <coiaprant@gmail.com>
    Reviewed-by: Filippo Valsorda <filippo@golang.org>
    Auto-Submit: Roland Shoemaker <roland@golang.org>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-on: https://go-review.googlesource.com/c/go/+/740061
    Reviewed-by: Nicholas Husin <husin@google.com>
    Reviewed-by: Nicholas Husin <nsh@golang.org>
    Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: Damien Neil <dneil@google.com>
    rolandshoemaker authored and gopherbot committed Jan 28, 2026
    Configuration menu
    Copy the full SHA
    5f07b22 View commit details
    Browse the repository at this point in the history
  6. [release-branch.go1.24] crypto/tls: check verifiedChains roots when r…

    …esuming sessions
    
    When resuming TLS sessions, on the server and client verify that the
    chains stored in the session state (verifiedChains) are still acceptable
    with regards to the Config by checking for the inclusion of the root in
    either ClientCAs (server) or RootCAs (client). This prevents resuming
    a session with a certificate chain that would be rejected during a full
    handshake due to an untrusted root.
    
    Updates #77113
    Updates #77355
    Updates CVE-2025-68121
    
    Change-Id: I11fe00909ef1961c24ecf80bf5b97f7b1121d359
    Reviewed-on: https://go-review.googlesource.com/c/go/+/737700
    Auto-Submit: Roland Shoemaker <roland@golang.org>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Coia Prant <coiaprant@gmail.com>
    Reviewed-by: Filippo Valsorda <filippo@golang.org>
    Reviewed-on: https://go-review.googlesource.com/c/go/+/740062
    Reviewed-by: Damien Neil <dneil@google.com>
    Reviewed-by: Nicholas Husin <nsh@golang.org>
    Reviewed-by: Nicholas Husin <husin@google.com>
    Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
    rolandshoemaker authored and gopherbot committed Jan 28, 2026
    Configuration menu
    Copy the full SHA
    cb75daf View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2026

  1. [release-branch.go1.24] crypto/tls: revalidate whole chain on resumpt…

    …ion on Windows and macOS
    
    TestHandshakeChangeRootCAsResumption and TestHandshakeGetConfigForClientDifferentClientCAs
    changed because previously rootA and rootB shared Subject and SPKI,
    which made the new full-chain revalidation check succeed, as the
    same leaf would verify against both roots.
    
    Updates #77376
    Fixes #77424
    
    Cq-Include-Trybots: luci.golang.try:go1.24-darwin-arm64-longtest
    Change-Id: I60bed694bdc621c9e83f1bd8a8224c016a6a6964
    Reviewed-on: https://go-review.googlesource.com/c/go/+/741361
    Auto-Submit: Filippo Valsorda <filippo@golang.org>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Reviewed-by: Roland Shoemaker <roland@golang.org>
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Auto-Submit: Roland Shoemaker <roland@golang.org>
    (cherry picked from commit b691a2e)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/741245
    Reviewed-by: Michael Pratt <mpratt@google.com>
    Auto-Submit: Michael Pratt <mpratt@google.com>
    FiloSottile authored and gopherbot committed Feb 3, 2026
    Configuration menu
    Copy the full SHA
    1a75aad View commit details
    Browse the repository at this point in the history
  2. [release-branch.go1.24] crypto/tls: document resumption behavior acro…

    …ss Configs
    
    Updates #77113
    Updates #77217
    Updates CVE-2025-68121
    
    Change-Id: Ia47904a9ed001275aad0243a6a0ce57e6a6a6964
    Reviewed-on: https://go-review.googlesource.com/c/go/+/740240
    LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
    Reviewed-by: Roland Shoemaker <roland@golang.org>
    Reviewed-by: Michael Pratt <mpratt@google.com>
    Auto-Submit: Filippo Valsorda <filippo@golang.org>
    (cherry picked from commit 1c9abbd)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/741180
    Auto-Submit: Michael Pratt <mpratt@google.com>
    FiloSottile authored and gopherbot committed Feb 3, 2026
    Configuration menu
    Copy the full SHA
    6a50131 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2026

  1. [release-branch.go1.24] go1.24.13

    Change-Id: I7747d3feed88695eeebbefcbcefc28f9a730d7db
    Reviewed-on: https://go-review.googlesource.com/c/go/+/741961
    Reviewed-by: Michael Pratt <mpratt@google.com>
    Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
    Auto-Submit: Gopher Robot <gobot@golang.org>
    TryBot-Bypass: Gopher Robot <gobot@golang.org>
    gopherbot committed Feb 4, 2026
    Configuration menu
    Copy the full SHA
    96e4e2b View commit details
    Browse the repository at this point in the history
Loading