Skip to content

feat(blooms): Add in-memory LRU cache for meta files #12862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 2, 2024
Merged

feat(blooms): Add in-memory LRU cache for meta files #12862

merged 3 commits into from
May 2, 2024

Conversation

@chaudum
Copy link
Contributor

@chaudum chaudum commented May 2, 2024

What this PR does / why we need it:

The in-memory LRU cache helps to reduce the amount of operations against memcached (or other configured cache backend).

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
chaudum added 3 commits May 2, 2024 11:11
@chaudum
Add in-memory LRU cache for metas
08cc1cd 
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudum
Increase max cache items for embedded cache
3ea670e 
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudum
Expose LRU cache settings
18f4442 
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudum chaudum requested a review from a team as a code owner May 2, 2024 16:49
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label May 2, 2024
@owen-d owen-d merged commit fcd544c into main May 2, 2024
@owen-d owen-d deleted the chaudum/metas-lru-cache branch May 2, 2024 17:52
shantanualsi pushed a commit that referenced this pull request May 6, 2024
@chaudum @shantanualsi
feat(blooms): Add in-memory LRU cache for meta files (#12862)
e62af86 
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
This was referenced May 6, 2024
Closed
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request May 20, 2024
Closed
This was referenced May 27, 2024
Closed
Closed
This was referenced Jun 10, 2024
Closed
Merged
@loki-gh-app loki-gh-app bot mentioned this pull request Jun 24, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 1, 2024
Closed
@grafanabot grafanabot mentioned this pull request Jul 2, 2024
Closed
This was referenced Jul 3, 2024
Closed
Closed
Closed
@RodrigoCMoraes RodrigoCMoraes mentioned this pull request Jul 12, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 15, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 22, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Oct 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories

2 participants

@chaudum @owen-d