feat: Add utf8 support to Pattern Lexer to support utf8 chars #13085
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Drain was producing patterns which did not match the original line in some cases. Example logline:
The issue was in the LogQL pattern matching code: The pattern parser was identifying the single UTF8 character
▶as 3 separate ASCII characters. This is actually a single 3-byte UTF encoded character.I added support for UTF-8 bytes in the Lexer to correctly identify them as 1 character in order to resolve this.
The lexer code was generated by Copilot, although I found an alternative implementation to check it against.