-
Notifications
You must be signed in to change notification settings - Fork 3.8k
fix: querier address in SingleBinary mode #13297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this LGTM, sorry we missed it and looks like it needs to be updated before we can merge. Could you update it (likely just the version number needs a bump)
|
Hi @slim-bean. Thanks for reviewing this.
It's not clear to me what needs to happen. Do you mean the version in |
Co-authored-by: J Stickler <julie.stickler@grafana.com>
What this PR does / why we need it:
Fix
loki.querierAddresshelper distributed check.The current if statement effectively checks if the string is non-empty.
Which issue(s) this PR fixes:
Fixes #12772
Fixes #12586
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR