Skip to content

Conversation

@salvacorts
Copy link
Contributor

What this PR does / why we need it:
Example of failing test:
https://github.com/grafana/loki/actions/runs/10212567007/job/28256159059

The plan is the same but on a different order than the expected from the test definition.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR
@salvacorts salvacorts marked this pull request as ready for review August 2, 2024 08:48
@salvacorts salvacorts requested a review from a team as a code owner August 2, 2024 08:48
@salvacorts salvacorts changed the title Fix: flaky test blockPlansForGaps Aug 2, 2024
@salvacorts salvacorts merged commit 37e33d4 into main Aug 14, 2024
@salvacorts salvacorts deleted the salvacorts/fix-flaky-test-bloom-planner branch August 14, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants