Skip to content

fix(detected labels): response when store label values are empty #13970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2024
Merged

fix(detected labels): response when store label values are empty #13970

merged 1 commit into from
Aug 27, 2024

Conversation

@shantanualsi
Copy link
Contributor

@shantanualsi shantanualsi commented Aug 27, 2024 •
edited
Loading

Detected labels API response adds labels whose values returned from store might be nil if they are static labels. This
PR adds an additional check to omit them.
@shantanualsi shantanualsi changed the title Fix detected labels response when store label values are empty Aug 27, 2024
@shantanualsi shantanualsi changed the title fix (detected labels): response when store label values are empty Aug 27, 2024
@shantanualsi shantanualsi marked this pull request as ready for review August 27, 2024 11:30
@shantanualsi shantanualsi requested a review from a team as a code owner August 27, 2024 11:30
cyriltovena
cyriltovena approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@shantanualsi shantanualsi merged commit 6f99af6 into main Aug 27, 2024
@shantanualsi shantanualsi deleted the shantanu/empty-cardinality-bugfix branch August 27, 2024 11:57
pascal-sochacki pushed a commit to pascal-sochacki/loki that referenced this pull request Aug 29, 2024
@shantanualsi @pascal-sochacki
fix(detected labels): response when store label values are empty (gra…
09e99a3 
…fana#13970)
pascal-sochacki pushed a commit to pascal-sochacki/loki that referenced this pull request Aug 29, 2024
@shantanualsi @pascal-sochacki
fix(detected labels): response when store label values are empty (gra…
948357b 
…fana#13970)
@loki-gh-app loki-gh-app bot mentioned this pull request Sep 9, 2024
Merged
@loki-gh-app loki-gh-app bot mentioned this pull request Sep 23, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Sep 30, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Oct 7, 2024
Closed
This was referenced Oct 14, 2024
Closed
Closed
This was referenced Oct 21, 2024
Closed
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Nov 4, 2024
Merged
@loki-gh-app loki-gh-app bot mentioned this pull request Nov 11, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Dec 4, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Dec 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M

2 participants

@shantanualsi @cyriltovena