-
Notifications
You must be signed in to change notification settings - Fork 3.7k
fix(helm): add default wal dir to ruler config #14920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a CHANGELOG entry, thanks!
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@trevorwhitney changelog entry done. We can continue with CI and merge. |
@thevops the helm chart has it's own CHANGELOG.md, please update that file instead |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
13d99d6
to
e6fa278
Compare
This comment has been minimized.
This comment has been minimized.
e6fa278
to
4a09c0d
Compare
This comment has been minimized.
This comment has been minimized.
4a09c0d
to
315952d
Compare
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Krzysztof Łuczak <krzysztof.luczak.pro@gmail.com>
315952d
to
67e7211
Compare
This comment has been minimized.
This comment has been minimized.
@trevorwhitney oh, sorry. |
This comment has been minimized.
This comment has been minimized.
Kubernetes Manifest Diff SummaryScenario: default-single-binary-values (Added: 0, Modified: 11, Removed: 0)
Summary:
Added FilesNo added files Modified Filesloki/templates/querier/deployment-querier.yaml*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/querier/deployment-querier.yaml 2024-11-29 17:26:42.255112576 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/querier/deployment-querier.yaml 2024-11-29 17:26:45.015128598 +0000
***************
*** 27,33 ****
template:
metadata:
annotations:
! checksum/config: 46f5a44df70788fd14ee74c61219c63987c7ae39eb9d4bc3096b30bc5369f62f
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name
--- 27,33 ----
template:
metadata:
annotations:
! checksum/config: 23c0e3e0fb3988c5707eed5ea5fbc643164357516f71671bebe1cd0ea48410b7
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name loki/templates/query-frontend/deployment-query-frontend.yaml*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/query-frontend/deployment-query-frontend.yaml 2024-11-29 17:26:42.255112576 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/query-frontend/deployment-query-frontend.yaml 2024-11-29 17:26:45.015128598 +0000
***************
*** 26,32 ****
template:
metadata:
annotations:
! checksum/config: 46f5a44df70788fd14ee74c61219c63987c7ae39eb9d4bc3096b30bc5369f62f
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name
--- 26,32 ----
template:
metadata:
annotations:
! checksum/config: 23c0e3e0fb3988c5707eed5ea5fbc643164357516f71671bebe1cd0ea48410b7
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name loki/templates/compactor/statefulset-compactor.yaml*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/compactor/statefulset-compactor.yaml 2024-11-29 17:26:42.255112576 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/compactor/statefulset-compactor.yaml 2024-11-29 17:26:45.015128598 +0000
***************
*** 28,34 ****
template:
metadata:
annotations:
! checksum/config: 46f5a44df70788fd14ee74c61219c63987c7ae39eb9d4bc3096b30bc5369f62f
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name
--- 28,34 ----
template:
metadata:
annotations:
! checksum/config: 23c0e3e0fb3988c5707eed5ea5fbc643164357516f71671bebe1cd0ea48410b7
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name loki/templates/config.yaml*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/config.yaml 2024-11-29 17:26:42.251112554 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/config.yaml 2024-11-29 17:26:45.015128598 +0000
***************
*** 92,97 ****
--- 92,99 ----
s3:
bucketnames: ruler
type: s3
+ wal:
+ dir: /var/loki/ruler-wal
runtime_config:
file: /etc/loki/runtime-config/runtime-config.yaml
schema_config: loki/templates/query-scheduler/deployment-query-scheduler.yaml*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/query-scheduler/deployment-query-scheduler.yaml 2024-11-29 17:26:42.255112576 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/query-scheduler/deployment-query-scheduler.yaml 2024-11-29 17:26:45.015128598 +0000
***************
*** 26,32 ****
template:
metadata:
annotations:
! checksum/config: 46f5a44df70788fd14ee74c61219c63987c7ae39eb9d4bc3096b30bc5369f62f
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name
--- 26,32 ----
template:
metadata:
annotations:
! checksum/config: 23c0e3e0fb3988c5707eed5ea5fbc643164357516f71671bebe1cd0ea48410b7
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name loki/templates/ruler/statefulset-ruler.yaml*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/ruler/statefulset-ruler.yaml 2024-11-29 17:26:42.255112576 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/ruler/statefulset-ruler.yaml 2024-11-29 17:26:45.015128598 +0000
***************
*** 24,30 ****
template:
metadata:
annotations:
! checksum/config: 46f5a44df70788fd14ee74c61219c63987c7ae39eb9d4bc3096b30bc5369f62f
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name
--- 24,30 ----
template:
metadata:
annotations:
! checksum/config: 23c0e3e0fb3988c5707eed5ea5fbc643164357516f71671bebe1cd0ea48410b7
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name loki/templates/index-gateway/statefulset-index-gateway.yaml*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/index-gateway/statefulset-index-gateway.yaml 2024-11-29 17:26:42.255112576 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/index-gateway/statefulset-index-gateway.yaml 2024-11-29 17:26:45.015128598 +0000
***************
*** 25,31 ****
template:
metadata:
annotations:
! checksum/config: 46f5a44df70788fd14ee74c61219c63987c7ae39eb9d4bc3096b30bc5369f62f
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name
--- 25,31 ----
template:
metadata:
annotations:
! checksum/config: 23c0e3e0fb3988c5707eed5ea5fbc643164357516f71671bebe1cd0ea48410b7
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name loki/templates/ingester/statefulset-ingester-zone-c.yaml*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/ingester/statefulset-ingester-zone-c.yaml 2024-11-29 17:26:42.255112576 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/ingester/statefulset-ingester-zone-c.yaml 2024-11-29 17:26:45.015128598 +0000
***************
*** 33,39 ****
template:
metadata:
annotations:
! checksum/config: 46f5a44df70788fd14ee74c61219c63987c7ae39eb9d4bc3096b30bc5369f62f
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name
--- 33,39 ----
template:
metadata:
annotations:
! checksum/config: 23c0e3e0fb3988c5707eed5ea5fbc643164357516f71671bebe1cd0ea48410b7
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name loki/templates/ingester/statefulset-ingester-zone-b.yaml*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/ingester/statefulset-ingester-zone-b.yaml 2024-11-29 17:26:42.255112576 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/ingester/statefulset-ingester-zone-b.yaml 2024-11-29 17:26:45.015128598 +0000
***************
*** 33,39 ****
template:
metadata:
annotations:
! checksum/config: 46f5a44df70788fd14ee74c61219c63987c7ae39eb9d4bc3096b30bc5369f62f
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name
--- 33,39 ----
template:
metadata:
annotations:
! checksum/config: 23c0e3e0fb3988c5707eed5ea5fbc643164357516f71671bebe1cd0ea48410b7
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name loki/templates/ingester/statefulset-ingester-zone-a.yaml*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/ingester/statefulset-ingester-zone-a.yaml 2024-11-29 17:26:42.255112576 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/ingester/statefulset-ingester-zone-a.yaml 2024-11-29 17:26:45.015128598 +0000
***************
*** 33,39 ****
template:
metadata:
annotations:
! checksum/config: 46f5a44df70788fd14ee74c61219c63987c7ae39eb9d4bc3096b30bc5369f62f
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name
--- 33,39 ----
template:
metadata:
annotations:
! checksum/config: 23c0e3e0fb3988c5707eed5ea5fbc643164357516f71671bebe1cd0ea48410b7
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name loki/templates/distributor/deployment-distributor.yaml*** /home/runner/work/loki/loki/output/base/default-single-binary-values/loki/templates/distributor/deployment-distributor.yaml 2024-11-29 17:26:42.255112576 +0000
--- /home/runner/work/loki/loki/output/pr/default-single-binary-values/loki/templates/distributor/deployment-distributor.yaml 2024-11-29 17:26:45.015128598 +0000
***************
*** 27,33 ****
template:
metadata:
annotations:
! checksum/config: 46f5a44df70788fd14ee74c61219c63987c7ae39eb9d4bc3096b30bc5369f62f
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name
--- 27,33 ----
template:
metadata:
annotations:
! checksum/config: 23c0e3e0fb3988c5707eed5ea5fbc643164357516f71671bebe1cd0ea48410b7
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name Removed FilesNo removed files Scenario: default-values (Added: 0, Modified: 4, Removed: 0)
Summary:
Added FilesNo added files Modified Filesloki/templates/read/deployment-read.yaml*** /home/runner/work/loki/loki/output/base/default-values/loki/templates/read/deployment-read.yaml 2024-11-29 17:26:42.351113099 +0000
--- /home/runner/work/loki/loki/output/pr/default-values/loki/templates/read/deployment-read.yaml 2024-11-29 17:26:45.107129137 +0000
***************
*** 27,33 ****
template:
metadata:
annotations:
! checksum/config: abacff2ab380333fcb8322e8c3987bee7ab648f9db87be2057b26c14d29228d5
labels:
app.kubernetes.io/part-of: memberlist
app.kubernetes.io/name: loki
--- 27,33 ----
template:
metadata:
annotations:
! checksum/config: a5dada926244101e9d800ee1a4c6fce53c4e4f05ddcc3cea305cc1073cb38e93
labels:
app.kubernetes.io/part-of: memberlist
app.kubernetes.io/name: loki loki/templates/config.yaml*** /home/runner/work/loki/loki/output/base/default-values/loki/templates/config.yaml 2024-11-29 17:26:42.351113099 +0000
--- /home/runner/work/loki/loki/output/pr/default-values/loki/templates/config.yaml 2024-11-29 17:26:45.107129137 +0000
***************
*** 87,92 ****
--- 87,94 ----
insecure: false
s3forcepathstyle: false
type: s3
+ wal:
+ dir: /var/loki/ruler-wal
runtime_config:
file: /etc/loki/runtime-config/runtime-config.yaml
schema_config: loki/templates/write/statefulset-write.yaml*** /home/runner/work/loki/loki/output/base/default-values/loki/templates/write/statefulset-write.yaml 2024-11-29 17:26:42.351113099 +0000
--- /home/runner/work/loki/loki/output/pr/default-values/loki/templates/write/statefulset-write.yaml 2024-11-29 17:26:45.111129160 +0000
***************
*** 28,34 ****
template:
metadata:
annotations:
! checksum/config: abacff2ab380333fcb8322e8c3987bee7ab648f9db87be2057b26c14d29228d5
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name
--- 28,34 ----
template:
metadata:
annotations:
! checksum/config: a5dada926244101e9d800ee1a4c6fce53c4e4f05ddcc3cea305cc1073cb38e93
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name loki/templates/backend/statefulset-backend.yaml*** /home/runner/work/loki/loki/output/base/default-values/loki/templates/backend/statefulset-backend.yaml 2024-11-29 17:26:42.351113099 +0000
--- /home/runner/work/loki/loki/output/pr/default-values/loki/templates/backend/statefulset-backend.yaml 2024-11-29 17:26:45.107129137 +0000
***************
*** 32,38 ****
template:
metadata:
annotations:
! checksum/config: abacff2ab380333fcb8322e8c3987bee7ab648f9db87be2057b26c14d29228d5
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name
--- 32,38 ----
template:
metadata:
annotations:
! checksum/config: a5dada926244101e9d800ee1a4c6fce53c4e4f05ddcc3cea305cc1073cb38e93
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name Removed FilesNo removed files Scenario: ingress-values (Added: 0, Modified: 4, Removed: 0)
Summary:
Added FilesNo added files Modified Filesloki/templates/read/deployment-read.yaml*** /home/runner/work/loki/loki/output/base/ingress-values/loki/templates/read/deployment-read.yaml 2024-11-29 17:26:42.447113623 +0000
--- /home/runner/work/loki/loki/output/pr/ingress-values/loki/templates/read/deployment-read.yaml 2024-11-29 17:26:45.203129698 +0000
***************
*** 27,33 ****
template:
metadata:
annotations:
! checksum/config: abacff2ab380333fcb8322e8c3987bee7ab648f9db87be2057b26c14d29228d5
labels:
app.kubernetes.io/part-of: memberlist
app.kubernetes.io/name: loki
--- 27,33 ----
template:
metadata:
annotations:
! checksum/config: a5dada926244101e9d800ee1a4c6fce53c4e4f05ddcc3cea305cc1073cb38e93
labels:
app.kubernetes.io/part-of: memberlist
app.kubernetes.io/name: loki loki/templates/config.yaml*** /home/runner/work/loki/loki/output/base/ingress-values/loki/templates/config.yaml 2024-11-29 17:26:42.443113601 +0000
--- /home/runner/work/loki/loki/output/pr/ingress-values/loki/templates/config.yaml 2024-11-29 17:26:45.203129698 +0000
***************
*** 87,92 ****
--- 87,94 ----
insecure: false
s3forcepathstyle: false
type: s3
+ wal:
+ dir: /var/loki/ruler-wal
runtime_config:
file: /etc/loki/runtime-config/runtime-config.yaml
schema_config: loki/templates/write/statefulset-write.yaml*** /home/runner/work/loki/loki/output/base/ingress-values/loki/templates/write/statefulset-write.yaml 2024-11-29 17:26:42.447113623 +0000
--- /home/runner/work/loki/loki/output/pr/ingress-values/loki/templates/write/statefulset-write.yaml 2024-11-29 17:26:45.203129698 +0000
***************
*** 28,34 ****
template:
metadata:
annotations:
! checksum/config: abacff2ab380333fcb8322e8c3987bee7ab648f9db87be2057b26c14d29228d5
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name
--- 28,34 ----
template:
metadata:
annotations:
! checksum/config: a5dada926244101e9d800ee1a4c6fce53c4e4f05ddcc3cea305cc1073cb38e93
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name loki/templates/backend/statefulset-backend.yaml*** /home/runner/work/loki/loki/output/base/ingress-values/loki/templates/backend/statefulset-backend.yaml 2024-11-29 17:26:42.447113623 +0000
--- /home/runner/work/loki/loki/output/pr/ingress-values/loki/templates/backend/statefulset-backend.yaml 2024-11-29 17:26:45.203129698 +0000
***************
*** 32,38 ****
template:
metadata:
annotations:
! checksum/config: abacff2ab380333fcb8322e8c3987bee7ab648f9db87be2057b26c14d29228d5
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name
--- 32,38 ----
template:
metadata:
annotations:
! checksum/config: a5dada926244101e9d800ee1a4c6fce53c4e4f05ddcc3cea305cc1073cb38e93
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name Removed FilesNo removed files Scenario: legacy-monitoring-values (Added: 0, Modified: 4, Removed: 0)
Summary:
Added FilesNo added files Modified Filesloki/templates/read/deployment-read.yaml*** /home/runner/work/loki/loki/output/base/legacy-monitoring-values/loki/templates/read/deployment-read.yaml 2024-11-29 17:26:42.547114168 +0000
--- /home/runner/work/loki/loki/output/pr/legacy-monitoring-values/loki/templates/read/deployment-read.yaml 2024-11-29 17:26:45.307130307 +0000
***************
*** 27,33 ****
template:
metadata:
annotations:
! checksum/config: abacff2ab380333fcb8322e8c3987bee7ab648f9db87be2057b26c14d29228d5
labels:
app.kubernetes.io/part-of: memberlist
app.kubernetes.io/name: loki
--- 27,33 ----
template:
metadata:
annotations:
! checksum/config: a5dada926244101e9d800ee1a4c6fce53c4e4f05ddcc3cea305cc1073cb38e93
labels:
app.kubernetes.io/part-of: memberlist
app.kubernetes.io/name: loki loki/templates/config.yaml*** /home/runner/work/loki/loki/output/base/legacy-monitoring-values/loki/templates/config.yaml 2024-11-29 17:26:42.547114168 +0000
--- /home/runner/work/loki/loki/output/pr/legacy-monitoring-values/loki/templates/config.yaml 2024-11-29 17:26:45.303130283 +0000
***************
*** 87,92 ****
--- 87,94 ----
insecure: false
s3forcepathstyle: false
type: s3
+ wal:
+ dir: /var/loki/ruler-wal
runtime_config:
file: /etc/loki/runtime-config/runtime-config.yaml
schema_config: loki/templates/write/statefulset-write.yaml*** /home/runner/work/loki/loki/output/base/legacy-monitoring-values/loki/templates/write/statefulset-write.yaml 2024-11-29 17:26:42.551114189 +0000
--- /home/runner/work/loki/loki/output/pr/legacy-monitoring-values/loki/templates/write/statefulset-write.yaml 2024-11-29 17:26:45.307130307 +0000
***************
*** 28,34 ****
template:
metadata:
annotations:
! checksum/config: abacff2ab380333fcb8322e8c3987bee7ab648f9db87be2057b26c14d29228d5
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name
--- 28,34 ----
template:
metadata:
annotations:
! checksum/config: a5dada926244101e9d800ee1a4c6fce53c4e4f05ddcc3cea305cc1073cb38e93
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name loki/templates/backend/statefulset-backend.yaml*** /home/runner/work/loki/loki/output/base/legacy-monitoring-values/loki/templates/backend/statefulset-backend.yaml 2024-11-29 17:26:42.547114168 +0000
--- /home/runner/work/loki/loki/output/pr/legacy-monitoring-values/loki/templates/backend/statefulset-backend.yaml 2024-11-29 17:26:45.307130307 +0000
***************
*** 32,38 ****
template:
metadata:
annotations:
! checksum/config: abacff2ab380333fcb8322e8c3987bee7ab648f9db87be2057b26c14d29228d5
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name
--- 32,38 ----
template:
metadata:
annotations:
! checksum/config: a5dada926244101e9d800ee1a4c6fce53c4e4f05ddcc3cea305cc1073cb38e93
labels:
app.kubernetes.io/name: loki
app.kubernetes.io/instance: loki-test-chart-name Removed FilesNo removed files Scenario: simple-scalable-aws-kube-irsa-values (Added: 0, Modified: 6, Removed: 0)
Summary:
Added FilesNo added files Modified Filesloki/templates/read/deployment-read.yaml*** /home/runner/work/loki/loki/output/base/simple-scalable-aws-kube-irsa-values/loki/templates/read/deployment-read.yaml 2024-11-29 17:26:42.655114789 +0000
--- /home/runner/work/loki/loki/output/pr/simple-scalable-aws-kube-irsa-values/loki/templates/read/deployment-read.yaml 2024-11-29 17:26:45.411130915 +0000
***************
*** 27,33 ****
template:
metadata:
annotations:
! checksum/config: 9e97cdc2e6228d40de8987fdd99274829f377a029b929041f4957a9a5d6c116b
labels:
app.kubernetes.io/part-of: memberlist
app.kubernetes.io/name: enterprise-logs
--- 27,33 ----
template:
metadata:
annotations:
! checksum/config: 8cfa6bbdb9a4dbb7b195fc7162e2fddac7836db36a03aa494881c1fc01f7c3ac
labels:
app.kubernetes.io/part-of: memberlist
app.kubernetes.io/name: enterprise-logs loki/templates/config.yaml*** /home/runner/work/loki/loki/output/base/simple-scalable-aws-kube-irsa-values/loki/templates/config.yaml 2024-11-29 17:26:42.655114789 +0000
--- /home/runner/work/loki/loki/output/pr/simple-scalable-aws-kube-irsa-values/loki/templates/config.yaml 2024-11-29 17:26:45.411130915 +0000
***************
*** 99,104 ****
--- 99,106 ----
region: eu-central-1
s3forcepathstyle: false
type: s3
+ wal:
+ dir: /var/loki/ruler-wal
runtime_config:
file: /etc/loki/runtime-config/runtime-config.yaml
schema_config: loki/templates/write/statefulset-write.yaml*** /home/runner/work/loki/loki/output/base/simple-scalable-aws-kube-irsa-values/loki/templates/write/statefulset-write.yaml 2024-11-29 17:26:42.655114789 +0000
--- /home/runner/work/loki/loki/output/pr/simple-scalable-aws-kube-irsa-values/loki/templates/write/statefulset-write.yaml 2024-11-29 17:26:45.411130915 +0000
***************
*** 28,34 ****
template:
metadata:
annotations:
! checksum/config: 9e97cdc2e6228d40de8987fdd99274829f377a029b929041f4957a9a5d6c116b
labels:
app.kubernetes.io/name: enterprise-logs
app.kubernetes.io/instance: loki-test-chart-name
--- 28,34 ----
template:
metadata:
annotations:
! checksum/config: 8cfa6bbdb9a4dbb7b195fc7162e2fddac7836db36a03aa494881c1fc01f7c3ac
labels:
app.kubernetes.io/name: enterprise-logs
app.kubernetes.io/instance: loki-test-chart-name loki/templates/gateway/deployment-gateway-enterprise.yaml*** /home/runner/work/loki/loki/output/base/simple-scalable-aws-kube-irsa-values/loki/templates/gateway/deployment-gateway-enterprise.yaml 2024-11-29 17:26:42.655114789 +0000
--- /home/runner/work/loki/loki/output/pr/simple-scalable-aws-kube-irsa-values/loki/templates/gateway/deployment-gateway-enterprise.yaml 2024-11-29 17:26:45.411130915 +0000
***************
*** 27,33 ****
app.kubernetes.io/instance: loki-test-chart-name
app.kubernetes.io/component: gateway
annotations:
! checksum/config: 9e97cdc2e6228d40de8987fdd99274829f377a029b929041f4957a9a5d6c116b
spec:
serviceAccountName: enterprise-logs
securityContext:
--- 27,33 ----
app.kubernetes.io/instance: loki-test-chart-name
app.kubernetes.io/component: gateway
annotations:
! checksum/config: 8cfa6bbdb9a4dbb7b195fc7162e2fddac7836db36a03aa494881c1fc01f7c3ac
spec:
serviceAccountName: enterprise-logs
securityContext: loki/templates/admin-api/deployment-admin-api.yaml*** /home/runner/work/loki/loki/output/base/simple-scalable-aws-kube-irsa-values/loki/templates/admin-api/deployment-admin-api.yaml 2024-11-29 17:26:42.655114789 +0000
--- /home/runner/work/loki/loki/output/pr/simple-scalable-aws-kube-irsa-values/loki/templates/admin-api/deployment-admin-api.yaml 2024-11-29 17:26:45.411130915 +0000
***************
*** 32,38 ****
target: admin-api
app.kubernetes.io/part-of: memberlist
annotations:
! checksum/config: 9e97cdc2e6228d40de8987fdd99274829f377a029b929041f4957a9a5d6c116b
spec:
serviceAccountName: enterprise-logs
securityContext:
--- 32,38 ----
target: admin-api
app.kubernetes.io/part-of: memberlist
annotations:
! checksum/config: 8cfa6bbdb9a4dbb7b195fc7162e2fddac7836db36a03aa494881c1fc01f7c3ac
spec:
serviceAccountName: enterprise-logs
securityContext: loki/templates/backend/statefulset-backend.yaml*** /home/runner/work/loki/loki/output/base/simple-scalable-aws-kube-irsa-values/loki/templates/backend/statefulset-backend.yaml 2024-11-29 17:26:42.655114789 +0000
--- /home/runner/work/loki/loki/output/pr/simple-scalable-aws-kube-irsa-values/loki/templates/backend/statefulset-backend.yaml 2024-11-29 17:26:45.411130915 +0000
***************
*** 32,38 ****
template:
metadata:
annotations:
! checksum/config: 9e97cdc2e6228d40de8987fdd99274829f377a029b929041f4957a9a5d6c116b
labels:
app.kubernetes.io/name: enterprise-logs
app.kubernetes.io/instance: loki-test-chart-name
--- 32,38 ----
template:
metadata:
annotations:
! checksum/config: 8cfa6bbdb9a4dbb7b195fc7162e2fddac7836db36a03aa494881c1fc01f7c3ac
labels:
app.kubernetes.io/name: enterprise-logs
app.kubernetes.io/instance: loki-test-chart-name Removed FilesNo removed files |
What this PR does / why we need it:
The change adds a default configuration for
rulerConfig
.There are many issues related to the lack of the setting from this Pull Requests. For example:
The issues are not directly related, but examples of configuration shared by people often contains such change. It's worth to add it since anyway users do it.
Which issue(s) this PR fixes:
Fixes -
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR