Skip to content

feat: Add icmpv6 protocol support for aws_lightsail_instance_public_ports #37703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 19, 2025
Merged

feat: Add icmpv6 protocol support for aws_lightsail_instance_public_ports #37703

merged 6 commits into from
Jun 19, 2025

Conversation

acwwat
Copy link
Contributor

@acwwat acwwat commented May 25, 2024 •
edited
Loading

Description

This PR is to add support for icmpv6 for the aws_lightsail_instance_public_ports resource.

Note that not all acceptance tests are passing due to perpetual changes which is tracked via #30286. I have thus only include test results of the two new test cases I added.

Relations

Closes #35526
Closes #30288

References

Referred to OpenInstancePublicPorts for specs and wordings.

Output from Acceptance Testing

Updated: 2025-06-14

$ make testacc TESTS=TestAccLightsailInstancePublicPorts_icmp PKG=lightsail
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.10 test ./internal/service/lightsail/... -v -count 1 -parallel 20 -run='TestAccLightsailInstancePublicPorts_icmp'  -timeout 360m -vet=off
2025/06/14 00:52:42 Initializing Terraform AWS Provider...
=== RUN   TestAccLightsailInstancePublicPorts_icmpPing
=== PAUSE TestAccLightsailInstancePublicPorts_icmpPing
=== RUN   TestAccLightsailInstancePublicPorts_icmpAll
=== PAUSE TestAccLightsailInstancePublicPorts_icmpAll
=== CONT  TestAccLightsailInstancePublicPorts_icmpPing
=== CONT  TestAccLightsailInstancePublicPorts_icmpAll
--- PASS: TestAccLightsailInstancePublicPorts_icmpAll (57.91s)
--- PASS: TestAccLightsailInstancePublicPorts_icmpPing (57.91s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  58.192s

$
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/lightsail Issues and PRs that pertain to the lightsail service. labels May 25, 2024
@terraform-aws-provider terraform-aws-provider bot added needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels May 25, 2024
@acwwat acwwat force-pushed the f-aws_lightsail_instance_public_ports-add_icmpv6_protocol_support branch 3 times, most recently from 8c638b5 to 127f850 Compare May 25, 2024 05:54
@acwwat acwwat mentioned this pull request May 25, 2024
Open
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels May 28, 2024
@acwwat acwwat force-pushed the f-aws_lightsail_instance_public_ports-add_icmpv6_protocol_support branch from 127f850 to b5b485a Compare June 14, 2025 04:54
@acwwat acwwat requested a review from a team as a code owner June 14, 2025 04:54
@jar-b jar-b self-assigned this Jun 16, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 16, 2025
jar-b added 2 commits June 16, 2025 15:03
@jar-b
r/aws_lightsail_instance_public_ports: handle NotFound errors on de…
29371f6 
…lete

Fixes `_disappears` acceptance test failures caused by unhandled `NotFound` errors. These errors will now be handled gracefully and skipped rather than returned to the user.

```console
% make testacc PKG=lightsail TESTS="TestAccLightsailInstancePublicPorts_disappears|TestAccLightsailInstancePublicPorts_icmp"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.10 test ./internal/service/lightsail/... -v -count 1 -parallel 20 -run='TestAccLightsailInstancePublicPorts_disappears|TestAccLightsailInstancePublicPorts_icmp'  -timeout 360m -vet=off
2025/06/16 15:02:01 Initializing Terraform AWS Provider...

--- PASS: TestAccLightsailInstancePublicPorts_disappears_Instance (52.43s)
--- PASS: TestAccLightsailInstancePublicPorts_icmpAll (52.92s)
--- PASS: TestAccLightsailInstancePublicPorts_icmpPing (53.15s)
--- PASS: TestAccLightsailInstancePublicPorts_disappears (54.23s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  59.794s
```
@jar-b
chore: fix changelog typos
cd1b2a8
jar-b
jar-b previously approved these changes Jun 16, 2025
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=lightsail TESTS="TestAccLightsailInstancePublicPorts_disappears|TestAccLightsailInstancePublicPorts_icmp"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.10 test ./internal/service/lightsail/... -v -count 1 -parallel 20 -run='TestAccLightsailInstancePublicPorts_disappears|TestAccLightsailInstancePublicPorts_icmp'  -timeout 360m -vet=off
2025/06/16 15:02:01 Initializing Terraform AWS Provider...

--- PASS: TestAccLightsailInstancePublicPorts_disappears_Instance (52.43s)
--- PASS: TestAccLightsailInstancePublicPorts_icmpAll (52.92s)
--- PASS: TestAccLightsailInstancePublicPorts_icmpPing (53.15s)
--- PASS: TestAccLightsailInstancePublicPorts_disappears (54.23s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  59.794s
jar-b
jar-b approved these changes Jun 19, 2025
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

Tests still passing after merging main:

% make testacc PKG=lightsail TESTS="TestAccLightsailInstancePublicPorts_disappears|TestAccLightsailInstancePublicPorts_icmp"
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.4 test ./internal/service/lightsail/... -v -count 1 -parallel 20 -run='TestAccLightsailInstancePublicPorts_disappears|TestAccLightsailInstancePublicPorts_icmp'  -timeout 360m -vet=off
2025/06/19 10:41:00 Creating Terraform AWS Provider (SDKv2-style)...
2025/06/19 10:41:00 Initializing Terraform AWS Provider (SDKv2-style)...

--- PASS: TestAccLightsailInstancePublicPorts_icmpPing (56.99s)
--- PASS: TestAccLightsailInstancePublicPorts_icmpAll (57.17s)
--- PASS: TestAccLightsailInstancePublicPorts_disappears (57.77s)
--- PASS: TestAccLightsailInstancePublicPorts_disappears_Instance (64.52s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  70.598s
ewbankkit
ewbankkit approved these changes Jun 19, 2025
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.
@jar-b
Copy link
Member

jar-b commented Jun 19, 2025

Thanks for your contribution, @acwwat! 🚀
@jar-b jar-b merged commit 6fad941 into hashicorp:main Jun 19, 2025
46 checks passed
@github-actions GitHub Actions
Copy link

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.
@github-actions github-actions bot added this to the v6.1.0 milestone Jun 19, 2025
@acwwat acwwat deleted the f-aws_lightsail_instance_public_ports-add_icmpv6_protocol_support branch June 22, 2025 04:04
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 26, 2025
@github-actions GitHub Actions
Copy link

This functionality has been released in v6.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. external-maintainer Contribution from a trusted external contributor. service/lightsail Issues and PRs that pertain to the lightsail service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
4 participants
@acwwat @jar-b @ewbankkit @justinretzolk