-
Notifications
You must be signed in to change notification settings - Fork 9.6k
feat: Add os_release_label arg to aws_emr_cluster #43018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add os_release_label arg to aws_emr_cluster #43018
Conversation
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible. |
81ae5a5
to
d6212bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccEMRCluster_osReleaseLabel\|TestAccEMRCluster_basic\|TestAccEMRCluster_upgradeV5_100_0' PKG=emr
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.10 test ./internal/service/emr/... -v -count 1 -parallel 20 -run=TestAccEMRCluster_osReleaseLabel\|TestAccEMRCluster_basic\|TestAccEMRCluster_upgradeV5_100_0 -timeout 360m -vet=off
2025/06/16 11:12:12 Initializing Terraform AWS Provider...
=== RUN TestAccEMRCluster_basic
=== PAUSE TestAccEMRCluster_basic
=== RUN TestAccEMRCluster_osReleaseLabel
=== PAUSE TestAccEMRCluster_osReleaseLabel
=== RUN TestAccEMRCluster_upgradeV5_100_0
=== PAUSE TestAccEMRCluster_upgradeV5_100_0
=== CONT TestAccEMRCluster_basic
=== CONT TestAccEMRCluster_upgradeV5_100_0
=== CONT TestAccEMRCluster_osReleaseLabel
--- PASS: TestAccEMRCluster_basic (292.57s)
--- PASS: TestAccEMRCluster_upgradeV5_100_0 (422.84s)
--- PASS: TestAccEMRCluster_osReleaseLabel (708.88s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/emr 713.775s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@acwwat Thanks for the contribution 🎉 👏. |
Warning This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them. Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed. |
This functionality has been released in v6.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
n/a
Description
This PR is to add the
os_release_label
argument to theaws_emr_cluster
resource.Note that there are three existing acceptance test case failures described below, but they are unrelated to this PR.
Relations
Closes #42977
References
Referred to RunJobFlow for specs and wordings.
Output from Acceptance Testing
Note that there are three unrelated test case that failed:
TestAccEMRCluster_ebs
andTestAccEMRCluster_CustomAMI_id
failed because the core and primary instances kept failing bootstrap with a timeout. I suspect this is related to the release and application being included in the configuration. I am not familiar with EMR enough to continue troubleshooting.TestAccEMRCluster_visibleToAllUsers
failed because thevisible_to_all_users
arg did not persist on an update. Looking at CloudTrail, it is as if Terraform didn't detect the change so it didn't make the API call to update the flag.I will open two separate issues for these acceptance test failures. Meanwhile I don't think they are related to this enhancement, so I'd like a maintainer to review and merge this PR to add the feature first.