r/aws_elasticsearch_domain: Disable publishing for log_publishing_options removed on Update

[ewbankkit]

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Prevents a perpetual diff.

Relations

Closes #5752.
Closes #14497.
Closes #25506.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccElasticsearchDomain_LogPublishingOptions_\|TestAccElasticsearchDomain_basic\|TestAccElasticsearchDomain_policy' PKG=elasticsearch ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.4 test ./internal/service/elasticsearch/... -v -count 1 -parallel 4  -run=TestAccElasticsearchDomain_LogPublishingOptions_\|TestAccElasticsearchDomain_basic\|TestAccElasticsearchDomain_policy -timeout 360m -vet=off
2025/06/19 08:34:11 Creating Terraform AWS Provider (SDKv2-style)...
2025/06/19 08:34:11 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccElasticsearchDomain_basic
=== PAUSE TestAccElasticsearchDomain_basic
=== RUN   TestAccElasticsearchDomain_LogPublishingOptions_indexSlowLogs
=== PAUSE TestAccElasticsearchDomain_LogPublishingOptions_indexSlowLogs
=== RUN   TestAccElasticsearchDomain_LogPublishingOptions_searchSlowLogs
=== PAUSE TestAccElasticsearchDomain_LogPublishingOptions_searchSlowLogs
=== RUN   TestAccElasticsearchDomain_LogPublishingOptions_esApplicationLogs
=== PAUSE TestAccElasticsearchDomain_LogPublishingOptions_esApplicationLogs
=== RUN   TestAccElasticsearchDomain_LogPublishingOptions_auditLogs
=== PAUSE TestAccElasticsearchDomain_LogPublishingOptions_auditLogs
=== RUN   TestAccElasticsearchDomain_LogPublishingOptions_disable
=== PAUSE TestAccElasticsearchDomain_LogPublishingOptions_disable
=== RUN   TestAccElasticsearchDomain_LogPublishingOptions_multiple
=== PAUSE TestAccElasticsearchDomain_LogPublishingOptions_multiple
=== RUN   TestAccElasticsearchDomain_policy
=== PAUSE TestAccElasticsearchDomain_policy
=== RUN   TestAccElasticsearchDomain_policyIgnoreEquivalent
=== PAUSE TestAccElasticsearchDomain_policyIgnoreEquivalent
=== CONT  TestAccElasticsearchDomain_basic
=== CONT  TestAccElasticsearchDomain_LogPublishingOptions_disable
=== CONT  TestAccElasticsearchDomain_LogPublishingOptions_esApplicationLogs
=== CONT  TestAccElasticsearchDomain_LogPublishingOptions_auditLogs
--- PASS: TestAccElasticsearchDomain_LogPublishingOptions_esApplicationLogs (771.65s)
=== CONT  TestAccElasticsearchDomain_LogPublishingOptions_searchSlowLogs
--- PASS: TestAccElasticsearchDomain_LogPublishingOptions_auditLogs (772.88s)
=== CONT  TestAccElasticsearchDomain_LogPublishingOptions_indexSlowLogs
--- PASS: TestAccElasticsearchDomain_basic (774.52s)
=== CONT  TestAccElasticsearchDomain_policy
--- PASS: TestAccElasticsearchDomain_LogPublishingOptions_disable (1670.34s)
=== CONT  TestAccElasticsearchDomain_policyIgnoreEquivalent
--- PASS: TestAccElasticsearchDomain_policy (1545.56s)
=== CONT  TestAccElasticsearchDomain_LogPublishingOptions_multiple
--- PASS: TestAccElasticsearchDomain_LogPublishingOptions_searchSlowLogs (1730.77s)
--- PASS: TestAccElasticsearchDomain_LogPublishingOptions_indexSlowLogs (1739.81s)
--- PASS: TestAccElasticsearchDomain_policyIgnoreEquivalent (1203.94s)
--- PASS: TestAccElasticsearchDomain_LogPublishingOptions_multiple (1924.80s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elasticsearch	4249.731s

% make testacc TESTARGS='-run=TestAccOpenSearchDomain_LogPublishingOptions_\|TestAccOpenSearchDomain_Policy\|TestAccOpenSearchDomain_basic' PKG=opensearch ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.4 test ./internal/service/opensearch/... -v -count 1 -parallel 4  -run=TestAccOpenSearchDomain_LogPublishingOptions_\|TestAccOpenSearchDomain_Policy\|TestAccOpenSearchDomain_basic -timeout 360m -vet=off
2025/06/19 10:23:07 Creating Terraform AWS Provider (SDKv2-style)...
2025/06/19 10:23:07 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccOpenSearchDomain_basic
=== PAUSE TestAccOpenSearchDomain_basic
=== RUN   TestAccOpenSearchDomain_LogPublishingOptions_indexSlowLogs
=== PAUSE TestAccOpenSearchDomain_LogPublishingOptions_indexSlowLogs
=== RUN   TestAccOpenSearchDomain_LogPublishingOptions_searchSlowLogs
=== PAUSE TestAccOpenSearchDomain_LogPublishingOptions_searchSlowLogs
=== RUN   TestAccOpenSearchDomain_LogPublishingOptions_applicationLogs
=== PAUSE TestAccOpenSearchDomain_LogPublishingOptions_applicationLogs
=== RUN   TestAccOpenSearchDomain_LogPublishingOptions_auditLogs
=== PAUSE TestAccOpenSearchDomain_LogPublishingOptions_auditLogs
=== RUN   TestAccOpenSearchDomain_LogPublishingOptions_disable
=== PAUSE TestAccOpenSearchDomain_LogPublishingOptions_disable
=== RUN   TestAccOpenSearchDomain_LogPublishingOptions_multiple
=== PAUSE TestAccOpenSearchDomain_LogPublishingOptions_multiple
=== RUN   TestAccOpenSearchDomain_Policy_basic
=== PAUSE TestAccOpenSearchDomain_Policy_basic
=== RUN   TestAccOpenSearchDomain_Policy_addPrincipal
=== PAUSE TestAccOpenSearchDomain_Policy_addPrincipal
=== RUN   TestAccOpenSearchDomain_Policy_ignoreEquivalent
=== PAUSE TestAccOpenSearchDomain_Policy_ignoreEquivalent
=== CONT  TestAccOpenSearchDomain_basic
=== CONT  TestAccOpenSearchDomain_LogPublishingOptions_disable
=== CONT  TestAccOpenSearchDomain_Policy_addPrincipal
=== CONT  TestAccOpenSearchDomain_Policy_ignoreEquivalent
--- PASS: TestAccOpenSearchDomain_basic (1866.34s)
=== CONT  TestAccOpenSearchDomain_Policy_basic
--- PASS: TestAccOpenSearchDomain_LogPublishingOptions_disable (1947.05s)
=== CONT  TestAccOpenSearchDomain_LogPublishingOptions_applicationLogs
--- PASS: TestAccOpenSearchDomain_Policy_ignoreEquivalent (1961.15s)
=== CONT  TestAccOpenSearchDomain_LogPublishingOptions_auditLogs
--- PASS: TestAccOpenSearchDomain_Policy_addPrincipal (1970.80s)
=== CONT  TestAccOpenSearchDomain_LogPublishingOptions_searchSlowLogs
--- PASS: TestAccOpenSearchDomain_LogPublishingOptions_searchSlowLogs (1647.58s)
=== CONT  TestAccOpenSearchDomain_LogPublishingOptions_indexSlowLogs
--- PASS: TestAccOpenSearchDomain_LogPublishingOptions_auditLogs (1782.92s)
=== CONT  TestAccOpenSearchDomain_LogPublishingOptions_multiple
--- PASS: TestAccOpenSearchDomain_LogPublishingOptions_applicationLogs (1835.67s)
--- PASS: TestAccOpenSearchDomain_Policy_basic (1968.46s)
--- PASS: TestAccOpenSearchDomain_LogPublishingOptions_indexSlowLogs (1731.29s)
--- PASS: TestAccOpenSearchDomain_LogPublishingOptions_multiple (2108.83s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opensearch	5857.834s

[github-actions]

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

• Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
• Please see our prioritization guide for additional information on how the maintainers handle prioritization.
• Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[jar-b]

LGTM 🚀

[github-actions]

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

[github-actions]

This functionality has been released in v6.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!