Skip to content

r/aws_s3tables_table: Add schema definition support #43112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 24, 2025

Conversation

drewtul
Copy link
Contributor

@drewtul drewtul commented Jun 19, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Adds schema definition support on create.

Note: Amazon Q Developer used to generate a decent portion of this.

Relations

Closes #41212

References

Output from Acceptance Testing

%  make testacc TESTS=TestAccS3TablesTable_ PKG=s3tables                                                                                                                                                                      <aws:terraform-testing>
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.4 test ./internal/service/s3tables/... -v -count 1 -parallel 20 -run='TestAccS3TablesTable_'  -timeout 360m -vet=off
2025/06/19 17:57:13 Creating Terraform AWS Provider (SDKv2-style)...
2025/06/19 17:57:13 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccS3TablesTable_basic
=== PAUSE TestAccS3TablesTable_basic
=== RUN   TestAccS3TablesTable_disappears
=== PAUSE TestAccS3TablesTable_disappears
=== RUN   TestAccS3TablesTable_rename
=== PAUSE TestAccS3TablesTable_rename
=== RUN   TestAccS3TablesTable_updateNamespace
=== PAUSE TestAccS3TablesTable_updateNamespace
=== RUN   TestAccS3TablesTable_updateNameAndNamespace
=== PAUSE TestAccS3TablesTable_updateNameAndNamespace
=== RUN   TestAccS3TablesTable_maintenanceConfiguration
=== PAUSE TestAccS3TablesTable_maintenanceConfiguration
=== RUN   TestAccS3TablesTable_encryptionConfiguration
=== PAUSE TestAccS3TablesTable_encryptionConfiguration
=== RUN   TestAccS3TablesTable_metadata
=== PAUSE TestAccS3TablesTable_metadata
=== CONT  TestAccS3TablesTable_basic
=== CONT  TestAccS3TablesTable_updateNameAndNamespace
=== CONT  TestAccS3TablesTable_encryptionConfiguration
=== CONT  TestAccS3TablesTable_metadata
=== CONT  TestAccS3TablesTable_rename
=== CONT  TestAccS3TablesTable_updateNamespace
=== CONT  TestAccS3TablesTable_disappears
=== CONT  TestAccS3TablesTable_maintenanceConfiguration
--- PASS: TestAccS3TablesTable_disappears (31.70s)
--- PASS: TestAccS3TablesTable_metadata (35.57s)
--- PASS: TestAccS3TablesTable_basic (36.02s)
--- PASS: TestAccS3TablesTable_encryptionConfiguration (44.80s)
--- PASS: TestAccS3TablesTable_rename (55.37s)
--- PASS: TestAccS3TablesTable_updateNameAndNamespace (55.56s)
--- PASS: TestAccS3TablesTable_updateNamespace (55.60s)
--- PASS: TestAccS3TablesTable_maintenanceConfiguration (59.39s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/s3tables   63.982s
Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/s3tables Issues and PRs that pertain to the s3tables service. size/XL Managed by automation to categorize the size of a PR. partner Contribution from a partner. labels Jun 19, 2025
@drewtul drewtul marked this pull request as ready for review June 19, 2025 19:12
@drewtul drewtul requested a review from a team as a code owner June 19, 2025 19:12
@ewbankkit ewbankkit self-assigned this Jun 19, 2025
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jun 19, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 19, 2025
@justinretzolk justinretzolk added the enhancement Requests to existing resources that expand the functionality or scope. label Jun 19, 2025
@ewbankkit ewbankkit force-pushed the f-s3tables-create-with-schema branch from e5afdae to e9d44d1 Compare June 23, 2025 19:34
ewbankkit
ewbankkit previously approved these changes Jun 23, 2025
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccS3TablesTable_' PKG=s3tables ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.4 test ./internal/service/s3tables/... -v -count 1 -parallel 3  -run=TestAccS3TablesTable_ -timeout 360m -vet=off
2025/06/23 15:34:31 Creating Terraform AWS Provider (SDKv2-style)...
2025/06/23 15:34:31 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccS3TablesTable_basic
=== PAUSE TestAccS3TablesTable_basic
=== RUN   TestAccS3TablesTable_disappears
=== PAUSE TestAccS3TablesTable_disappears
=== RUN   TestAccS3TablesTable_rename
=== PAUSE TestAccS3TablesTable_rename
=== RUN   TestAccS3TablesTable_updateNamespace
=== PAUSE TestAccS3TablesTable_updateNamespace
=== RUN   TestAccS3TablesTable_updateNameAndNamespace
=== PAUSE TestAccS3TablesTable_updateNameAndNamespace
=== RUN   TestAccS3TablesTable_maintenanceConfiguration
=== PAUSE TestAccS3TablesTable_maintenanceConfiguration
=== RUN   TestAccS3TablesTable_encryptionConfiguration
=== PAUSE TestAccS3TablesTable_encryptionConfiguration
=== RUN   TestAccS3TablesTable_metadata
=== PAUSE TestAccS3TablesTable_metadata
=== CONT  TestAccS3TablesTable_basic
=== CONT  TestAccS3TablesTable_updateNameAndNamespace
=== CONT  TestAccS3TablesTable_encryptionConfiguration
--- PASS: TestAccS3TablesTable_basic (21.37s)
=== CONT  TestAccS3TablesTable_metadata
--- PASS: TestAccS3TablesTable_encryptionConfiguration (27.87s)
=== CONT  TestAccS3TablesTable_rename
--- PASS: TestAccS3TablesTable_updateNameAndNamespace (33.60s)
=== CONT  TestAccS3TablesTable_updateNamespace
--- PASS: TestAccS3TablesTable_metadata (19.58s)
=== CONT  TestAccS3TablesTable_disappears
--- PASS: TestAccS3TablesTable_disappears (16.89s)
=== CONT  TestAccS3TablesTable_maintenanceConfiguration
--- PASS: TestAccS3TablesTable_rename (32.33s)
--- PASS: TestAccS3TablesTable_updateNamespace (32.02s)
--- PASS: TestAccS3TablesTable_maintenanceConfiguration (34.47s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/s3tables	97.285s
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit
Copy link
Contributor

@drewtul Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 70acdbd into hashicorp:main Jun 24, 2025
45 checks passed
Copy link

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v6.1.0 milestone Jun 24, 2025
@drewtul drewtul deleted the f-s3tables-create-with-schema branch June 24, 2025 18:44
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jun 26, 2025
Copy link

This functionality has been released in v6.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. partner Contribution from a partner. service/s3tables Issues and PRs that pertain to the s3tables service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
4 participants