-
Notifications
You must be signed in to change notification settings - Fork 9.6k
r/aws_s3tables_table: Add schema definition support #43112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_s3tables_table: Add schema definition support #43112
Conversation
…to f-s3tables-create-with-schema
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
e5afdae
to
e9d44d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccS3TablesTable_' PKG=s3tables ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.4 test ./internal/service/s3tables/... -v -count 1 -parallel 3 -run=TestAccS3TablesTable_ -timeout 360m -vet=off
2025/06/23 15:34:31 Creating Terraform AWS Provider (SDKv2-style)...
2025/06/23 15:34:31 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN TestAccS3TablesTable_basic
=== PAUSE TestAccS3TablesTable_basic
=== RUN TestAccS3TablesTable_disappears
=== PAUSE TestAccS3TablesTable_disappears
=== RUN TestAccS3TablesTable_rename
=== PAUSE TestAccS3TablesTable_rename
=== RUN TestAccS3TablesTable_updateNamespace
=== PAUSE TestAccS3TablesTable_updateNamespace
=== RUN TestAccS3TablesTable_updateNameAndNamespace
=== PAUSE TestAccS3TablesTable_updateNameAndNamespace
=== RUN TestAccS3TablesTable_maintenanceConfiguration
=== PAUSE TestAccS3TablesTable_maintenanceConfiguration
=== RUN TestAccS3TablesTable_encryptionConfiguration
=== PAUSE TestAccS3TablesTable_encryptionConfiguration
=== RUN TestAccS3TablesTable_metadata
=== PAUSE TestAccS3TablesTable_metadata
=== CONT TestAccS3TablesTable_basic
=== CONT TestAccS3TablesTable_updateNameAndNamespace
=== CONT TestAccS3TablesTable_encryptionConfiguration
--- PASS: TestAccS3TablesTable_basic (21.37s)
=== CONT TestAccS3TablesTable_metadata
--- PASS: TestAccS3TablesTable_encryptionConfiguration (27.87s)
=== CONT TestAccS3TablesTable_rename
--- PASS: TestAccS3TablesTable_updateNameAndNamespace (33.60s)
=== CONT TestAccS3TablesTable_updateNamespace
--- PASS: TestAccS3TablesTable_metadata (19.58s)
=== CONT TestAccS3TablesTable_disappears
--- PASS: TestAccS3TablesTable_disappears (16.89s)
=== CONT TestAccS3TablesTable_maintenanceConfiguration
--- PASS: TestAccS3TablesTable_rename (32.33s)
--- PASS: TestAccS3TablesTable_updateNamespace (32.02s)
--- PASS: TestAccS3TablesTable_maintenanceConfiguration (34.47s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/s3tables 97.285s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@drewtul Thanks for the contribution 🎉 👏. |
Warning This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them. Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed. |
This functionality has been released in v6.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Description
Adds schema definition support on create.
Note: Amazon Q Developer used to generate a decent portion of this.
Relations
Closes #41212
References
Output from Acceptance Testing