-
Notifications
You must be signed in to change notification settings - Fork 9.6k
feat: add support for job_config #43136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for job_config #43136
Conversation
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccAmplify_serial/^App$$/basic\|TestAccAmplify_serial/^App$$/JobConfig' PKG=amplify
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.4 test ./internal/service/amplify/... -v -count 1 -parallel 20 -run=TestAccAmplify_serial/^App$/basic\|TestAccAmplify_serial/^App$/JobConfig -timeout 360m -vet=off
2025/06/25 11:02:06 Creating Terraform AWS Provider (SDKv2-style)...
2025/06/25 11:02:06 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN TestAccAmplify_serial
=== PAUSE TestAccAmplify_serial
=== CONT TestAccAmplify_serial
=== RUN TestAccAmplify_serial/App
=== RUN TestAccAmplify_serial/App/basic
=== RUN TestAccAmplify_serial/App/JobConfig
--- PASS: TestAccAmplify_serial (574.56s)
--- PASS: TestAccAmplify_serial/App (574.56s)
--- PASS: TestAccAmplify_serial/App/basic (283.88s)
--- PASS: TestAccAmplify_serial/App/JobConfig (290.68s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/amplify 579.371s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
@stefanfreitag Thanks for the contribution 🎉 👏. |
Warning This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them. Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed. |
This functionality has been released in v6.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
None.
Description
As mentioned in #43126 users can specify the build compute type for Amplify Apps.
AWS introduced a job configuration object (
JobConfig
) and madeBuildComputeType
part of it.Supported values for
BuildComputeType
areSTANDARD_8GB
,LARGE_16GB
, andXLARGE_72GB
. If no value is specified by user, Amplify uses theSTANDARD_8GB
default.Additional change in the test code
During test execution I noticed that
TestAccApp_basic
fails withthis is due to the fact that the default value for the cache config type is
AMPLIFY_MANAGED_NO_COOKIES
and notAMPLIFY_MANAGED
. This is documented here. The check has been updated to reflect this.Relations
Closes #43126
References
Output from Acceptance Testing
There seems to be an issue with test checking on
basic_auth_credentials
(have not touched this). Looks like the API returns no longer the username/password combination, but username/ hash.The execution of all Amplify-related tests is still ongoing on my (slow) system. Would be cool, if you can run the tests on your end. Current status on my end is as below.
The new test
TestAccAmplify_serial/App/JobConfig
for the feature succeeds without error.