Skip to content

r/aws_cur_report_definition: Allow an empty ("") value for s3_prefix #43159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 24, 2025

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jun 24, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

For backwards compatibility we must allow the empty string ("") as a valid value for the now Required s3_prefix argument.

Relations

Closes #43153.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccCUR_serial/ReportDefinition' PKG=cur 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.24.4 test ./internal/service/cur/... -v -count 1 -parallel 20  -run=TestAccCUR_serial/ReportDefinition -timeout 360m -vet=off
2025/06/24 11:57:51 Creating Terraform AWS Provider (SDKv2-style)...
2025/06/24 11:57:51 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccCUR_serial
=== PAUSE TestAccCUR_serial
=== CONT  TestAccCUR_serial
=== RUN   TestAccCUR_serial/ReportDefinition
=== RUN   TestAccCUR_serial/ReportDefinition/basic
=== RUN   TestAccCUR_serial/ReportDefinition/disappears
=== RUN   TestAccCUR_serial/ReportDefinition/athena
=== RUN   TestAccCUR_serial/ReportDefinition/refresh
=== RUN   TestAccCUR_serial/ReportDefinition/DataSource_basic
=== RUN   TestAccCUR_serial/ReportDefinition/DataSource_additional
=== RUN   TestAccCUR_serial/ReportDefinition/tags
=== PAUSE TestAccCUR_serial/ReportDefinition/tags
=== RUN   TestAccCUR_serial/ReportDefinition/textOrCsv
=== RUN   TestAccCUR_serial/ReportDefinition/parquet
=== RUN   TestAccCUR_serial/ReportDefinition/overwrite
=== RUN   TestAccCUR_serial/ReportDefinition/upgradeNoPrefixFromV5
=== CONT  TestAccCUR_serial/ReportDefinition/tags
--- PASS: TestAccCUR_serial (336.30s)
    --- PASS: TestAccCUR_serial/ReportDefinition (289.76s)
        --- PASS: TestAccCUR_serial/ReportDefinition/basic (37.37s)
        --- PASS: TestAccCUR_serial/ReportDefinition/disappears (23.01s)
        --- PASS: TestAccCUR_serial/ReportDefinition/athena (24.78s)
        --- PASS: TestAccCUR_serial/ReportDefinition/refresh (25.01s)
        --- PASS: TestAccCUR_serial/ReportDefinition/DataSource_basic (22.89s)
        --- PASS: TestAccCUR_serial/ReportDefinition/DataSource_additional (22.47s)
        --- PASS: TestAccCUR_serial/ReportDefinition/textOrCsv (24.26s)
        --- PASS: TestAccCUR_serial/ReportDefinition/parquet (24.26s)
        --- PASS: TestAccCUR_serial/ReportDefinition/overwrite (24.18s)
        --- PASS: TestAccCUR_serial/ReportDefinition/upgradeNoPrefixFromV5 (61.51s)
        --- PASS: TestAccCUR_serial/ReportDefinition/tags (46.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cur	341.226s
@ewbankkit ewbankkit requested a review from a team as a code owner June 24, 2025 15:56
Copy link

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.
@github-actions github-actions bot added prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/cur Issues and PRs that pertain to the cur service. size/M Managed by automation to categorize the size of a PR. and removed prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Jun 24, 2025
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit ewbankkit merged commit 2beb194 into main Jun 24, 2025
46 of 48 checks passed
@ewbankkit ewbankkit deleted the b-aws_cur_report_definition.s3_prefix-empty branch June 24, 2025 18:16
Copy link

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v6.1.0 milestone Jun 24, 2025
terraform-aws-provider bot pushed a commit that referenced this pull request Jun 24, 2025
@sebastien-plaquet
Copy link

Thank you @ewbankkit !

Best regards.
Sébastien

Copy link

This functionality has been released in v6.1.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. service/cur Issues and PRs that pertain to the cur service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
3 participants