Skip to content

Escape exemplar keys to fix invalid key errors #5995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2024
Merged

Escape exemplar keys to fix invalid key errors #5995

merged 1 commit into from
Nov 22, 2024

Conversation

@dashpole
Copy link
Contributor

Fixes #5936
@dashpole dashpole force-pushed the fix_exemplar_sanitization branch from a978599 to 5644ee0 Compare November 21, 2024 20:50
@dashpole dashpole changed the title Sanitize exemplar keys to fix invalid key errors Nov 21, 2024
@dashpole dashpole mentioned this pull request Nov 21, 2024
Open
@dashpole dashpole added the bug Something isn't working label Nov 21, 2024
@codecov
Copy link

codecov bot commented Nov 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.1%. Comparing base (99c3c66) to head (5644ee0).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #5995     +/-   ##
=======================================
- Coverage   82.1%   82.1%   -0.1%     
=======================================
  Files        273     273             
  Lines      23615   23616      +1     
=======================================
  Hits       19400   19400             
- Misses      3870    3871      +1     
  Partials     345     345

see 3 files with indirect coverage changes

---- 🚨 Try these New Features:
@pellared pellared added this to the v1.33.0 milestone Nov 22, 2024
@pellared pellared added the pkg:exporter:prometheus Related to the Prometheus exporter package label Nov 22, 2024
@dashpole dashpole merged commit 2edaccb into open-telemetry:main Nov 22, 2024
36 checks passed
@dashpole dashpole deleted the fix_exemplar_sanitization branch November 22, 2024 18:39
@jachym-tousek-keboola jachym-tousek-keboola mentioned this pull request Dec 3, 2024
Merged
@MrAlias MrAlias mentioned this pull request Dec 12, 2024
Merged
MrAlias added a commit that referenced this pull request Dec 12, 2024
@MrAlias
Release v1.33.0 (#6035)
8c38f80 
### Added

- Add `Reset` method to `SpanRecorder` in
`go.opentelemetry.io/otel/sdk/trace/tracetest`. (#5994)
- Add `EnabledInstrument` interface in
`go.opentelemetry.io/otel/sdk/metric/internal/x`. This is an
experimental interface that is implemented by synchronous instruments
provided by `go.opentelemetry.io/otel/sdk/metric`. Users can use it to
avoid performing computationally expensive operations when recording
measurements. It does not fall within the scope of the OpenTelemetry Go
versioning and stability [policy](./VERSIONING.md) and it may be changed
in backwards incompatible ways or removed in feature releases. (#6016)

### Changed

- The default global API now supports full auto-instrumentation from the
`go.opentelemetry.io/auto` package. See that package for more
information. (#5920)
- Propagate non-retryable error messages to client in
`go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp`. (#5929)
- Propagate non-retryable error messages to client in
`go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp`.
(#5929)
- Propagate non-retryable error messages to client in
`go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp`.
(#5929)
- Performance improvements for attribute value `AsStringSlice`,
`AsFloat64Slice`, `AsInt64Slice`, `AsBoolSlice`. (#6011)
- Change `EnabledParameters` to have a `Severity` field instead of a
getter and setter in `go.opentelemetry.io/otel/log`. (#6009)

### Fixed

- Fix inconsistent request body closing in
`go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp`. (#5954)
- Fix inconsistent request body closing in
`go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp`.
(#5954)
- Fix inconsistent request body closing in
`go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp`.
(#5954)
- Fix invalid exemplar keys in
`go.opentelemetry.io/otel/exporters/prometheus`. (#5995)
- Fix attribute value truncation in
`go.opentelemetry.io/otel/sdk/trace`. (#5997)
- Fix attribute value truncation in `go.opentelemetry.io/otel/sdk/log`.
(#6032)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working pkg:exporter:prometheus Related to the Prometheus exporter package

4 participants

@dashpole @dmathieu @pellared @MrAlias