Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: redis/go-redis
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v9.10.0
Choose a base ref
...
head repository: redis/go-redis
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v9.11.0
Choose a head ref
  • 16 commits
  • 44 files changed
  • 11 contributors

Commits on Jun 9, 2025

  1. fix: insert entry during iterating over a map (#3398)

    Signed-off-by: fukua95 <fukua95@gmail.com>
    cxljs authored Jun 9, 2025
    Configuration menu
    Copy the full SHA
    858ecda View commit details
    Browse the repository at this point in the history
  2. fix: check if the shard exists to avoid returning nil (#3396)

    Signed-off-by: fukua95 <fukua95@gmail.com>
    cxljs authored Jun 9, 2025
    Configuration menu
    Copy the full SHA
    0f40ae3 View commit details
    Browse the repository at this point in the history
  3. perf: reduce unnecessary memory allocation (#3399)

    Signed-off-by: fukua95 <fukua95@gmail.com>
    Co-authored-by: Nedyalko Dyakov <1547186+ndyakov@users.noreply.github.com>
    cxljs and ndyakov authored Jun 9, 2025
    Configuration menu
    Copy the full SHA
    eb40ac8 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2025

  1. test: refactor TestBasicCredentials using table-driven tests (#3406)

    * test: refactor TestBasicCredentials using table-driven tests
    
    * Included additional edge cases:
    
    - Empty passwords
    - Special characters
    - Long strings
    - Unicode characters
    iamamirsalehi authored Jun 16, 2025
    Configuration menu
    Copy the full SHA
    e2295c7 View commit details
    Browse the repository at this point in the history
  2. chore: remove a redundant method (#3401)

    Signed-off-by: fukua95 <fukua95@gmail.com>
    Co-authored-by: Nedyalko Dyakov <1547186+ndyakov@users.noreply.github.com>
    cxljs and ndyakov authored Jun 16, 2025
    Configuration menu
    Copy the full SHA
    82b00cc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6871741 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2025

  1. fix(txpipeline): should return error on multi/exec on multiple slots …

    …[CAE-1028] (#3408)
    
    * fix(txpipeline): should return error on multi/exec on multiple slots
    
    * fix(txpipeline): test normal tx pipeline behaviour
    
    * chore(err): Extract crossslot err and add test
    
    * fix(txpipeline): short curcuit the tx if there are no commands
    
    * chore(tests): validate keys are in different slots
    ndyakov authored Jun 18, 2025
    Configuration menu
    Copy the full SHA
    4c635cc View commit details
    Browse the repository at this point in the history
  2. [CAE-1046] fix(loading): cache the loaded flag for slave nodes (#3410)

    * fix(loading): cache the loaded flag for slave nodes
    
    * fix(lint): make linter happy
    ndyakov authored Jun 18, 2025
    Configuration menu
    Copy the full SHA
    f4358ac View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2025

  1. Configuration menu
    Copy the full SHA
    7d97cc1 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2025

  1. chore(deps): bump rojopolis/spellcheck-github-actions (#3414)

    Bumps [rojopolis/spellcheck-github-actions](https://github.com/rojopolis/spellcheck-github-actions) from 0.49.0 to 0.51.0.
    - [Release notes](https://github.com/rojopolis/spellcheck-github-actions/releases)
    - [Changelog](https://github.com/rojopolis/spellcheck-github-actions/blob/master/CHANGELOG.md)
    - [Commits](rojopolis/spellcheck-github-actions@0.49.0...0.51.0)
    
    ---
    updated-dependencies:
    - dependency-name: rojopolis/spellcheck-github-actions
      dependency-version: 0.51.0
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Jun 23, 2025
    Configuration menu
    Copy the full SHA
    e642856 View commit details
    Browse the repository at this point in the history
  2. DOC-5229 probabilistic data type examples (#3413)

    * DOC-5078 added basic vector set examples
    
    * DOC-5078 formatting and extra comments
    
    * DOC-5078 fixed nondeterministic test
    
    * wip(tests): run doctests for vector sets on redis 8 only
    
    * DOC-5229 added probabilistic data type examples
    
    ---------
    
    Co-authored-by: Nedyalko Dyakov <nedyalko.dyakov@gmail.com>
    andy-stark-redis and ndyakov authored Jun 23, 2025
    Configuration menu
    Copy the full SHA
    884f997 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2025

  1. fix(txpipeline): keyless commands should take the slot of the keyed (#…

    …3411)
    
    * fix(txpipeline): keyless commands should take the slot of the keyed commands
    
    * fix(txpipeline): extract only keyed cmds from all cmds
    
    * chore(test): Add tests for keyless cmds and txpipeline
    
    * fix(cmdSlot): Add preferred random slot
    
    * fix(cmdSlot): Add shortlist of keyless cmds
    
    * chore(test): Fix ring test
    
    * fix(keylessCommands): Add list of keyless commands
    
    Add list of keyless Commands based on the Commands output
    for redis 8
    
    * chore(txPipeline): refactor slottedCommands impl
    
    * fix(osscluster): typo
    ndyakov authored Jun 24, 2025
    Configuration menu
    Copy the full SHA
    05f42e2 View commit details
    Browse the repository at this point in the history
  2. feat(redisotel): add WithCallerEnabled option (#3415)

    * feat(redisotel): add WithCaller option
    
    Allow the disabling the collection of the `code.function`, `code.filepath` and `code.lineno` tracing attributes.
    When setting `WithCaller(false)` overall performance is increased as the "expensive" `runtime.Callers` and `runtime.(*Frames).Next` calls are no longer needed.
    
    * chore(redisotel): improve docblock language
    
    * chore(redisotel): rename `WithCaller` to `WithCallerEnabled`
    
    ---------
    
    Co-authored-by: Nedyalko Dyakov <1547186+ndyakov@users.noreply.github.com>
    boekkooi-impossiblecloud and ndyakov authored Jun 24, 2025
    Configuration menu
    Copy the full SHA
    fa475cb View commit details
    Browse the repository at this point in the history
  3. feat(client): Add CredentialsProvider field to UniversalOptions (#2927)

    * Add CredentialsProvider field to universal client
    
    * fix(options): Add credentials providers to universal options and pass to client options
    
    * chore(ring): Add missing fields in building clientOptions
    
    ---------
    
    Co-authored-by: ofekshenawa <104765379+ofekshenawa@users.noreply.github.com>
    Co-authored-by: Nedyalko Dyakov <nedyalko.dyakov@gmail.com>
    Co-authored-by: Nedyalko Dyakov <1547186+ndyakov@users.noreply.github.com>
    4 people authored Jun 24, 2025
    Configuration menu
    Copy the full SHA
    0383d08 View commit details
    Browse the repository at this point in the history
  4. Set correct cluster slot for scan commands, similarly to Java's Jedis…

    … client (#2623)
    
    - At present, the `scan` command is dispatched to a random slot.
    - As far as I can tell, the scanX family of commands are not cluster aware (e.g. don't redirect the client to the correct slot).
    - You can see [here](https://github.com/redis/jedis/blob/869dc0bb6625b85c8bf15bf1361bde485a304338/src/main/java/redis/clients/jedis/ShardedCommandObjects.java#L101), the Jedis client calling `processKey` on the match argument, and this is what this PR also does.
    
    We've had this patch running in production, and it seems to work well for us.
    
    For further thought:
    - Continuing looking at other Redis clients (e.g. Jedis), they outright [reject as invalid](https://github.com/redis/jedis/blob/869dc0bb6625b85c8bf15bf1361bde485a304338/src/main/java/redis/clients/jedis/ShardedCommandObjects.java#L98) any scan command that does not include a hash-tag. Presumably this has the advantage of users not being surprised when their scan produces no results when a random server is picked.
    - Perhaps it would be sensible for go-redis to do the same also?
    
    Co-authored-by: Nedyalko Dyakov <1547186+ndyakov@users.noreply.github.com>
    pete-woods and ndyakov authored Jun 24, 2025
    Configuration menu
    Copy the full SHA
    4ac591c View commit details
    Browse the repository at this point in the history
  5. chore(release): v9.11.0 (#3416)

    * chore(release): update version to 9.11.0
    
    * chore(release): Add Release Notes for v9.11.0
    ndyakov authored Jun 24, 2025
    Configuration menu
    Copy the full SHA
    0decfdc View commit details
    Browse the repository at this point in the history
Loading