-
-
Notifications
You must be signed in to change notification settings - Fork 233
Comparing changes
Open a pull request
base repository: twmb/franz-go
base: v1.19.0
head repository: twmb/franz-go
compare: v1.19.1
- 10 commits
- 7 files changed
- 2 contributors
Commits on May 3, 2025
-
sr: refactor DialTLSConfig option so it is stored in client
* also added basic test suite for the implementation
Configuration menu - View commit details
-
Copy full SHA for 08a491d - Browse repository at this point
Copy the full SHA 08a491dView commit details
Commits on May 4, 2025
-
Configuration menu - View commit details
-
Copy full SHA for 6239fe3 - Browse repository at this point
Copy the full SHA 6239fe3View commit details -
Configuration menu - View commit details
-
Copy full SHA for b10e36d - Browse repository at this point
Copy the full SHA b10e36dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b947f04 - Browse repository at this point
Copy the full SHA b947f04View commit details -
Configuration menu - View commit details
-
Copy full SHA for 737a404 - Browse repository at this point
Copy the full SHA 737a404View commit details
Commits on May 8, 2025
-
Merge pull request #978 from hhromic/hhromic/sr-tlscfg
sr: refactor DialTLSConfig option so it is stored in client
Configuration menu - View commit details
-
Copy full SHA for 72e1646 - Browse repository at this point
Copy the full SHA 72e1646View commit details
Commits on May 9, 2025
-
kgo bugfix: ApiVersions replies only with key 18, not all keys
This fixes a bug that has existed in this codebase forever, and only now finally can occur. In Kafka 2.4, Kafka introduced KIP-511, bumping ApiVersion to v3. I misread the KIP and assumed that the broker would send ALL API keys when the broker did not understand the version of the ApiVersions request we were sending. In franz-go, if the client detects an UNSUPPORTED_VERSION error, * Brokers pre 2.4 would outright send nothing; we would downgrade our request to v0 and retry. This worked. * Brokers post 2.4, I deserialized the response as v0 and assumed I had all keys. As it turns out, the broker returns only _one_ key, which is the version of ApiVersions that the broker supports. This would allow the client to re-request ApiVersions with the highest version the broker supports. This was never a problem until Kafka 4, which finally bumped ApiVersions to version 4. The client now sends v4. The client would get UNSUPPORTED_VERSIONS, unmarshal as v0, and only have one key set. Now, we unmarshal as v0 and then re-request as whatever version the broker says it supports. This also adds a github action to test against Kafka 3.8, which should prevent regressions as the library moves further and further into the future. Closes #1009, #1010.
Configuration menu - View commit details
-
Copy full SHA for 50aa74f - Browse repository at this point
Copy the full SHA 50aa74fView commit details -
Merge pull request #1011 from twmb/apiversions_zk
kgo bugfix: ApiVersions replies only with key 18, not all keys
Configuration menu - View commit details
-
Copy full SHA for 10f80e1 - Browse repository at this point
Copy the full SHA 10f80e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for cdc3e5b - Browse repository at this point
Copy the full SHA cdc3e5bView commit details -
Merge pull request #1012 from twmb/changelog-v1.19.1
changelog: update for v1.19.1
Configuration menu - View commit details
-
Copy full SHA for 84c3469 - Browse repository at this point
Copy the full SHA 84c3469View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.19.0...v1.19.1