Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: twmb/franz-go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.19.0
Choose a base ref
...
head repository: twmb/franz-go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.19.1
Choose a head ref
  • 10 commits
  • 7 files changed
  • 2 contributors

Commits on May 3, 2025

  1. sr: refactor DialTLSConfig option so it is stored in client

    * also added basic test suite for the implementation
    hhromic committed May 3, 2025
    Configuration menu
    Copy the full SHA
    08a491d View commit details
    Browse the repository at this point in the history

Commits on May 4, 2025

  1. Configuration menu
    Copy the full SHA
    6239fe3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b10e36d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b947f04 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    737a404 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2025

  1. Merge pull request #978 from hhromic/hhromic/sr-tlscfg

    sr: refactor DialTLSConfig option so it is stored in client
    twmb authored May 8, 2025
    Configuration menu
    Copy the full SHA
    72e1646 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2025

  1. kgo bugfix: ApiVersions replies only with key 18, not all keys

    This fixes a bug that has existed in this codebase forever, and only
    now finally can occur.
    
    In Kafka 2.4, Kafka introduced KIP-511, bumping ApiVersion to v3.
    
    I misread the KIP and assumed that the broker would send ALL API keys
    when the broker did not understand the version of the ApiVersions
    request we were sending.
    
    In franz-go, if the client detects an UNSUPPORTED_VERSION error,
    
    * Brokers pre 2.4 would outright send nothing; we would downgrade our
      request to v0 and retry. This worked.
    
    * Brokers post 2.4, I deserialized the response as v0 and assumed I had
      all keys.
    
    As it turns out, the broker returns only _one_ key, which is the version
    of ApiVersions that the broker supports. This would allow the client to
    re-request ApiVersions with the highest version the broker supports.
    
    This was never a problem until Kafka 4, which finally bumped ApiVersions
    to version 4. The client now sends v4. The client would get
    UNSUPPORTED_VERSIONS, unmarshal as v0, and only have one key set.
    
    Now, we unmarshal as v0 and then re-request as whatever version the
    broker says it supports.
    
    This also adds a github action to test against Kafka 3.8, which should
    prevent regressions as the library moves further and further into the
    future.
    
    Closes #1009, #1010.
    twmb committed May 9, 2025
    Configuration menu
    Copy the full SHA
    50aa74f View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1011 from twmb/apiversions_zk

    kgo bugfix: ApiVersions replies only with key 18, not all keys
    twmb authored May 9, 2025
    Configuration menu
    Copy the full SHA
    10f80e1 View commit details
    Browse the repository at this point in the history
  3. changelog: update for v1.19.1

    twmb committed May 9, 2025
    Configuration menu
    Copy the full SHA
    cdc3e5b View commit details
    Browse the repository at this point in the history
  4. Merge pull request #1012 from twmb/changelog-v1.19.1

    changelog: update for v1.19.1
    twmb authored May 9, 2025
    Configuration menu
    Copy the full SHA
    84c3469 View commit details
    Browse the repository at this point in the history
Loading