Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: twmb/franz-go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.19.1
Choose a base ref
...
head repository: twmb/franz-go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.19.2
Choose a head ref
  • 12 commits
  • 27 files changed
  • 3 contributors

Commits on May 10, 2025

  1. Configuration menu
    Copy the full SHA
    c8eee45 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #963 from hhromic/hhromic/sr-add-optvalues

    sr: add `Client.OptValue` and `Client.OptValues` functions
    twmb authored May 10, 2025
    Configuration menu
    Copy the full SHA
    a87ca01 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2025

  1. kfake: updates

    * update all requests to latest kafka 4 stuff -- most have no new
      behavior (for only the supported requests!)
    * bump deps
    twmb committed May 12, 2025
    Configuration menu
    Copy the full SHA
    e6a9591 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1014 from twmb/kfake

    kfake: updates
    twmb authored May 12, 2025
    Configuration menu
    Copy the full SHA
    fc65dcf View commit details
    Browse the repository at this point in the history

Commits on May 13, 2025

  1. sr: Add logger function to schema registry client

    It includes 3 new client options to set the
    logger function and the logger level.
    
    It mirrors kgo's Logger and LogLevel definitions,
    making it easy to use any existing kgo logging
    functionality you may already be using in this
    package as well.
    r-vasquez committed May 13, 2025
    Configuration menu
    Copy the full SHA
    5d128fd View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1015 from r-vasquez/sr/add-log-hook-2

    sr: Add logger function to schema registry client
    twmb authored May 13, 2025
    Configuration menu
    Copy the full SHA
    35305c1 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2025

  1. kgo bugfix: fix data race in fetch response handling

    Code in 2020 assumed that handleReqResp would only read a few safe
    fields forever. Code added in 2022 started reading fields from cursor,
    which could be modified concurrently when handling a metadata response.
    
    There is little reason to run handleReqResp independent of a fetch
    session -- there is minimal CPU blocking.
    
    By handling responses inline in a consumer session, we can be
    *guaranteed* that there is no race with metadata handling (or other
    things) since an active consumer session blocks concurrent updates that
    would affect the consumer session.
    
    Closes #1018.
    twmb committed May 14, 2025
    Configuration menu
    Copy the full SHA
    8a36481 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2025

  1. kgo: fix KIP-890 handling of the transaction.version feature

    Kafka introduced "features" in the ApiVersions response a long time ago
    during Kafka 2.6. This was never used in clients, and I did not add
    support for features to franz-go.
    
    Well, Kafka 4.0 finally started using features in clients.
    
    KIP-890 -- which does not mention the exact feature name
    "transaction.version" -- requires clients to only opt into "part 2" of
    the KIP if transaction.version >= 2.
    
    What this means is that if you were talking to Kafka 4 but had not yet
    enabled transactions in the cluster, transactions would not work.
    
    I audited a bit of the Java client code and discovered a few other
    things that I hadn't implemented -- for these, I point to the lack of
    actually calling out protocol version bumps in the KIP and mentioning
    the changes in like, 5 words:
    
    * AddOffsetsToTxn is no longer sent if we use TxnOffsetCommit v5+ (same
      principle as AddPartitionsToTxn not being sent for Produce v12+)
    
    * TxnOffsetCommit is pinned to v4 unless we detect kip890p2
    
    * EndTxn is pinned to v4 until we BEGIN a transaction with kip890p2
    
    * If we end and were pinned to v4 but then detect the cluster supports
      kip890p2, we re-init our producer ID (Java client does this to
      simplify things as we opt into p2)
    
    * Produce is pinned to v11 if we are transactional and kip890p2 is not
      supported (same as Java client)
    
    Closes #1017.
    twmb committed May 15, 2025
    Configuration menu
    Copy the full SHA
    dda08fd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4e6ca38 View commit details
    Browse the repository at this point in the history
  3. README: note KIP-1022 handling

    Well, we support transaction.version v2 now...
    twmb committed May 15, 2025
    Configuration menu
    Copy the full SHA
    f370649 View commit details
    Browse the repository at this point in the history
  4. CHANGELOG: note incoming v1.19.2

    twmb committed May 15, 2025
    Configuration menu
    Copy the full SHA
    4611477 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #1019 from twmb/bugs

    Bugfixes
    twmb authored May 15, 2025
    Configuration menu
    Copy the full SHA
    50fc7bc View commit details
    Browse the repository at this point in the history
Loading