-
-
Notifications
You must be signed in to change notification settings - Fork 233
Comparing changes
Open a pull request
base repository: twmb/franz-go
base: v1.19.1
head repository: twmb/franz-go
compare: v1.19.2
- 12 commits
- 27 files changed
- 3 contributors
Commits on May 10, 2025
-
Configuration menu - View commit details
-
Copy full SHA for c8eee45 - Browse repository at this point
Copy the full SHA c8eee45View commit details -
Merge pull request #963 from hhromic/hhromic/sr-add-optvalues
sr: add `Client.OptValue` and `Client.OptValues` functions
Configuration menu - View commit details
-
Copy full SHA for a87ca01 - Browse repository at this point
Copy the full SHA a87ca01View commit details
Commits on May 12, 2025
-
* update all requests to latest kafka 4 stuff -- most have no new behavior (for only the supported requests!) * bump deps
Configuration menu - View commit details
-
Copy full SHA for e6a9591 - Browse repository at this point
Copy the full SHA e6a9591View commit details -
Configuration menu - View commit details
-
Copy full SHA for fc65dcf - Browse repository at this point
Copy the full SHA fc65dcfView commit details
Commits on May 13, 2025
-
sr: Add logger function to schema registry client
It includes 3 new client options to set the logger function and the logger level. It mirrors kgo's Logger and LogLevel definitions, making it easy to use any existing kgo logging functionality you may already be using in this package as well.
Configuration menu - View commit details
-
Copy full SHA for 5d128fd - Browse repository at this point
Copy the full SHA 5d128fdView commit details -
Merge pull request #1015 from r-vasquez/sr/add-log-hook-2
sr: Add logger function to schema registry client
Configuration menu - View commit details
-
Copy full SHA for 35305c1 - Browse repository at this point
Copy the full SHA 35305c1View commit details
Commits on May 14, 2025
-
kgo bugfix: fix data race in fetch response handling
Code in 2020 assumed that handleReqResp would only read a few safe fields forever. Code added in 2022 started reading fields from cursor, which could be modified concurrently when handling a metadata response. There is little reason to run handleReqResp independent of a fetch session -- there is minimal CPU blocking. By handling responses inline in a consumer session, we can be *guaranteed* that there is no race with metadata handling (or other things) since an active consumer session blocks concurrent updates that would affect the consumer session. Closes #1018.
Configuration menu - View commit details
-
Copy full SHA for 8a36481 - Browse repository at this point
Copy the full SHA 8a36481View commit details
Commits on May 15, 2025
-
kgo: fix KIP-890 handling of the transaction.version feature
Kafka introduced "features" in the ApiVersions response a long time ago during Kafka 2.6. This was never used in clients, and I did not add support for features to franz-go. Well, Kafka 4.0 finally started using features in clients. KIP-890 -- which does not mention the exact feature name "transaction.version" -- requires clients to only opt into "part 2" of the KIP if transaction.version >= 2. What this means is that if you were talking to Kafka 4 but had not yet enabled transactions in the cluster, transactions would not work. I audited a bit of the Java client code and discovered a few other things that I hadn't implemented -- for these, I point to the lack of actually calling out protocol version bumps in the KIP and mentioning the changes in like, 5 words: * AddOffsetsToTxn is no longer sent if we use TxnOffsetCommit v5+ (same principle as AddPartitionsToTxn not being sent for Produce v12+) * TxnOffsetCommit is pinned to v4 unless we detect kip890p2 * EndTxn is pinned to v4 until we BEGIN a transaction with kip890p2 * If we end and were pinned to v4 but then detect the cluster supports kip890p2, we re-init our producer ID (Java client does this to simplify things as we opt into p2) * Produce is pinned to v11 if we are transactional and kip890p2 is not supported (same as Java client) Closes #1017.
Configuration menu - View commit details
-
Copy full SHA for dda08fd - Browse repository at this point
Copy the full SHA dda08fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e6ca38 - Browse repository at this point
Copy the full SHA 4e6ca38View commit details -
README: note KIP-1022 handling
Well, we support transaction.version v2 now...
Configuration menu - View commit details
-
Copy full SHA for f370649 - Browse repository at this point
Copy the full SHA f370649View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4611477 - Browse repository at this point
Copy the full SHA 4611477View commit details -
Configuration menu - View commit details
-
Copy full SHA for 50fc7bc - Browse repository at this point
Copy the full SHA 50fc7bcView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.19.1...v1.19.2