Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: twmb/franz-go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.19.2
Choose a base ref
...
head repository: twmb/franz-go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.19.3
Choose a head ref
  • 3 commits
  • 4 files changed
  • 1 contributor

Commits on May 15, 2025

  1. kgo: remove pinReq wrapping request 

    Every time I've added some behavior that uses pinReq in a new way,
there's been a bug. The fundamental problem is that pinReq wrapping a
kmsg.Request: removes any extra optional interface (is txn req, is group
req); breaks all type switches; is confusing to handle.

This moves pinReq from a wrapper to a value to carry along with the
context. This makes it a lot easier to reason about how pinReq will
break a reqest, because the answer is: it wont.

This requires a big switchup in how versions are handled in broker.go;
IMO the code actually is easier to reason about with min&max.

Locally tested against Kafka 4, Kafka 3.9, and Kafka 2.8; integ tests
will run against 4 and 3.9. I also inserted some panics to triple verify
that pinReq in sharding was actually used somewhere -- it is, for
AddPartitionsToTxn, where we pinMax on pre-4.0 versions.

Closes #1017.
    @twmb
    twmb committed May 15, 2025
    Configuration menu
    Copy the full SHA
    a13f633 View commit details
    Browse the repository at this point in the history

  2. note v1.19.3

    @twmb
    twmb committed May 15, 2025
    Configuration menu
    Copy the full SHA
    05e3235 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #1021 from twmb/1017 

    kgo: remove pinReq wrapping request
    @twmb
    twmb authored May 15, 2025
    Configuration menu
    Copy the full SHA
    604ad6e View commit details
    Browse the repository at this point in the history
Loading