Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: twmb/franz-go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.19.3
Choose a base ref
...
head repository: twmb/franz-go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.19.4
Choose a head ref
  • 6 commits
  • 5 files changed
  • 1 contributor

Commits on May 16, 2025

  1. kgo bugfix: guard sink batch field access more 

    1.19.0 introduced access to `batch.tries` while appending a request
(inside the batch mutex). For some reason, this was the one field in a
batch that I accessed outside the batch mutex in `bumpRepeatedLoadErr`.
That field has been moved inside the mutex.

Closes #1024.
    @twmb
    twmb committed May 16, 2025
    Configuration menu
    Copy the full SHA
    7a5ddce View commit details
    Browse the repository at this point in the history

  2. kgo: fix data read/write race on ctx variable 

    1.19.3 introduced a read/write race for a context variable. The fix is
to copy the ctx variable to a goroutine local ctx variable before
overwriting it.

Closes #1023.
    @twmb
    twmb committed May 16, 2025
    Configuration menu
    Copy the full SHA
    d310cab View commit details
    Browse the repository at this point in the history

Commits on May 19, 2025

  1. kgo: retry connection reset by peer from ApiVersions to work around… 

    … EventHubs

See commit and #1022 for more details.

Closes #1022.
    @twmb
    twmb committed May 19, 2025
    Configuration menu
    Copy the full SHA
    7910f6b View commit details
    Browse the repository at this point in the history

Commits on May 20, 2025

  1. Merge pull request #1026 from twmb/bugs 

    Bugs
    @twmb
    twmb authored May 20, 2025
    Configuration menu
    Copy the full SHA
    edcf726 View commit details
    Browse the repository at this point in the history

  2. changelog for 1.19.4

    @twmb
    twmb committed May 20, 2025
    Configuration menu
    Copy the full SHA
    0d3d262 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #1029 from twmb/changelog-1.19.4 

    changelog for 1.19.4
    @twmb
    twmb authored May 20, 2025
    Configuration menu
    Copy the full SHA
    29cb50b View commit details
    Browse the repository at this point in the history
Loading