Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfix the priority of stdin and in #796
Merged
Conversation
|
CIL |
|
@feich-ms this seems to be missing updates to chatdown..? |
|
@vishwacsena, I already scanned all the code including chatdown, found that the --in already has higher priority than stdin there and mslg tool does not accept stdin, so they have no changes. |
|
@vishwacsena, does this look good to go for you? |
munozemilio
added a commit
that referenced
this pull request
May 26, 2020
* fix the priority of stdin and in * fix the same issue in bf luis:generate * repalce all priority between stdin and --in * fix logic * remove only in luis build tests
munozemilio
added a commit
that referenced
this pull request
May 27, 2020
* Update dialog:merge tests around projects (#784) * Updating tests. * Merge branch '4.9' into chrimc/test Add nuget semver. * Change test to avoid checking path parts. * Follow package.json dependencies. * Fix merge match. * fix (#792) Co-authored-by: Vishwac Sena Kannan <vishwacsenakannan@MININT-GO8OQNV.redmond.corp.microsoft.com> * Fix to remove validation. (#793) Co-authored-by: Vishwac Sena Kannan <vishwacsenakannan@Vishwacs-MBP.guest.corp.microsoft.com> * fix the priority of stdin and in (#796) * fix the priority of stdin and in * fix the same issue in bf luis:generate * repalce all priority between stdin and --in * fix logic * remove only in luis build tests * Fix for direct luis direct version publish (#798) * Remove LUIS sdk and replace with direct http request * Removing unused line of code * fix (#802) Co-authored-by: Vishwac Sena Kannan <vishwacsenakannan@MININT-GO8OQNV.redmond.corp.microsoft.com> * fix (#803) Co-authored-by: Vishwac Sena Kannan <vishwacsenakannan@MININT-GO8OQNV.redmond.corp.microsoft.com> Co-authored-by: Emilio Munoz <emmunozp@microsoft.com> * Various fixes to bf-lu (#813) * various fixes. * fixes * updates * updates * fix for luis:build issue. * updates for nDepth reference resolver. * Update luis:build to create result using luis() Co-authored-by: Vishwac Sena Kannan <vishwacsenakannan@MININT-GO8OQNV.redmond.corp.microsoft.com> Co-authored-by: Vishwac Sena Kannan <vishwacsenakannan@Vishwacs-MBP.guest.corp.microsoft.com> Co-authored-by: Vishwac Sena Kannan <vishwacsenakannan@za-lyshange1811.africa.corp.microsoft.com> * Set build version * resolve qnamaker build issues (#812) * write out endpointKeys to console for qnamaker build * qnamaker:build do not write .dialog if no --out is specified * fix typo Co-authored-by: Emilio Munoz <emmunozp@microsoft.com> * resolve luis build issues (#804) * luis build do not write dialogs if no --out specified * qnamaker:build do not write .dialog if no --out is specified * fix suffix issue in luis build * revert qnamaker changes in this PR and add to another * fix typo Co-authored-by: Emilio Munoz <emmunozp@microsoft.com> * Adding missing code lost in merges * Fixing merge * Adding missing test files * Fixing readme files Co-authored-by: Chris McConnell <chrimc@microsoft.com> Co-authored-by: Vishwac Sena Kannan <vishwack@hotmail.com> Co-authored-by: Vishwac Sena Kannan <vishwacsenakannan@MININT-GO8OQNV.redmond.corp.microsoft.com> Co-authored-by: Vishwac Sena Kannan <vishwacsenakannan@Vishwacs-MBP.guest.corp.microsoft.com> Co-authored-by: Fei Chen <43032123+feich-ms@users.noreply.github.com> Co-authored-by: Vishwac Sena Kannan <vishwacsenakannan@za-lyshange1811.africa.corp.microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
fix issue #790