Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate README.md #719
Update README.md #719
Conversation
Fixed the ServiceBindingRequest YAML to use the proper "apiVersion" and "kind", and updated the "spec" to use "applicationSelector" and "backingServiceSelector".
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @DuncanDoyle. Thanks for your PR. I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixed the ServiceBindingRequest YAML to use the proper "apiVersion" and "kind", and updated the "spec" to use "applicationSelector" and "backingServiceSelector".
Motivation
ServiceBinding YAML in the README does not work with latest ServiceBindingOperator.
Changes
YAML now use ServiceBindingRequest with correct "spec" ("applicationSelector" and "backingServiceSelector") instead of the "ServiceBinding"
Testing
Walk through the README and apply the YAML.
For further more details refer the CONTRIBUTING.md