The Wayback Machine - https://web.archive.org/web/20220619184153/https://github.com/rust-lang/rust/issues/77071
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support stack probing for arm64 (aarch64) #77071

Open
tmandry opened this issue Sep 22, 2020 · 7 comments
Open

Support stack probing for arm64 (aarch64) #77071

tmandry opened this issue Sep 22, 2020 · 7 comments
Labels
A-LLVM A-stack-probe C-tracking-issue O-AArch64

Comments

@tmandry
Copy link
Contributor

@tmandry tmandry commented Sep 22, 2020

Background: #43241

This issue is to track implementation of stack probing on arm64. Most of the work necessary is in in LLVM, but this is a convenient place to track progress and final support in the Rust compiler.

Implementation: @cuviper has suggested using LLVM's inline-asm support for stack probing: #43241 (comment). It does not yet support arm64.

External trackers:

@tmandry tmandry added the C-tracking-issue label Sep 22, 2020
@jonas-schievink jonas-schievink added the O-ARM label Sep 22, 2020
@pietroalbini
Copy link
Member

@pietroalbini pietroalbini commented Sep 22, 2020

@rustbot ping arm

@rustbot
Copy link
Collaborator

@rustbot rustbot commented Sep 22, 2020

Hey ARM Group! This bug has been identified as a good "ARM candidate".
In case it's useful, here are some instructions for tackling these sorts of
bugs. Maybe take a look?
Thanks! <3

cc @JamieCunliffe @joaopaulocarreiro @raw-bin @Stammark @vigoux

@tmandry
Copy link
Contributor Author

@tmandry tmandry commented Feb 13, 2021

Hi @raw-bin, what's the status of this? As I recall this work was planned to land as part of LLVM 12, but I haven't seen updates on the Linaro tracker yet.

@raw-bin
Copy link

@raw-bin raw-bin commented Feb 13, 2021

@raw-bin
Copy link

@raw-bin raw-bin commented Feb 23, 2021

Hi @tmandry, folks.

Apologies for the delay.

There has been good progress.

Please note the following patches that have been posted by Linaro for review:

https://reviews.llvm.org/D96004
https://reviews.llvm.org/D96005
https://reviews.llvm.org/D96006
https://reviews.llvm.org/D96007

At present Linaro is blocking on review.

If possible, please do chime in.

I will provide further updates as needed.

Cheers

@tmandry
Copy link
Contributor Author

@tmandry tmandry commented Feb 23, 2021

Great, thanks for the update! Let me ask around to see if I can help get those patches reviewed.

@jyn514 jyn514 added the A-LLVM label Mar 15, 2021
@workingjubilee workingjubilee added O-AArch64 and removed O-ARM labels Mar 18, 2022
@joshtriplett
Copy link
Member

@joshtriplett joshtriplett commented May 24, 2022

What's the current state of this? What needs to happen to get working stack probes on aarch64?

@yaahc yaahc added the A-stack-probe label Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-LLVM A-stack-probe C-tracking-issue O-AArch64
9 participants