fix: apply expanduser to dotenv_path#615
Open
veeceey wants to merge 1 commit intotheskumar:mainfrom
Open
Conversation
Apply os.path.expanduser() / Path.expanduser() to dotenv_path so that ~ is properly expanded to the user's home directory. The fix preserves the original type (str stays str, Path stays Path) and is applied in DotEnv.__init__, set_key, and unset_key.
Author
|
Friendly ping - any chance someone could take a look at this when they get a chance? Happy to make any changes if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
os.path.expanduser()(forstrpaths) andPath.expanduser()(forPathobjects) todotenv_pathso that~is properly expanded to the user's home directorystrinputs remainstr,Pathinputs remainPathDotEnv.__init__,set_key(), andunset_key()— all places wheredotenv_pathis used directlyFixes #525
Test plan
test_main.pypass with no modificationsdotenv_path="~/.env"correctly expands to the full home directory pathPath("~/.env")correctly expands viaPath.expanduser()~are unchangedNoneis handled correctly (no expansion attempted)