Closed Bug 1979826 Opened 3 months ago Closed 1 month ago

Search dropdown doesn't open consistently with enter/space/down

Categories

(Firefox :: Address Bar, defect, P2)

Firefox 141
defect

Tracking

()

VERIFIED FIXED
145 Branch
Tracking Status
firefox-esr140 --- unaffected
firefox143 --- wontfix
firefox144 --- verified
firefox145 --- verified

People

(Reporter: tol, Assigned: daisuke)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [sng])

Attachments

(3 files)

Attached video Video showing the bug

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:141.0) Gecko/20100101 Firefox/141.0

Steps to reproduce:

  • Open a web page
  • Click on the address bar (URL is selected)
  • Type something, e.g. a search query
  • [Shift]+[Tab] to select search dropdown
  • Press [Enter] or [Space] to try to enter dropdown

Actual results:

Focus/selected item switches to the first result below the address bar (a search with the default search engine).

Expected results:

The dropdown should be expanded, so another search engine can be selected.

Component: Untriaged → Address Bar

Hello, thank you for the bug report!
Unfortunately I couldn’t reproduce this issue. Would you be so kind as to answer a few questions so we can investigate this further?

Thank you.

Flags: needinfo?(tol)

We can reproduce this when testing the latest nightly. This currently seems to behave differently across platforms.

Additionally on my Mac, it seems worse when there's a page visited/something in the address bar to begin with - if you open up a new tab, and then start entering, shift-tab and space/enter/down works properly.

Blocks: 1939598
Severity: -- → S2
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(tol)
Priority: -- → P2
Summary: Search dropdown not selectable by keyboard navigation → Search dropdown doesn't open consistently with enter/space/down
Whiteboard: [sng]
Assignee: nobody → daisuke
Status: NEW → ASSIGNED
Keywords: regression
Regressed by: 1966384

Set release status flags based on info from the regressing bug 1966384

Pushed by dakatsuka.birchill@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/c691e4fa5f90 https://hg.mozilla.org/integration/autoland/rev/2cd50a6a1a2a Set focused element when popuphiding to avoid focusing processing upon popupshowing r=daleharvey
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 145 Branch
Flags: in-testsuite+
QA Whiteboard: [search] [qa-triage-done-c145/b144] [qa-ver-needed-c145/b144]

The patch landed in nightly and beta is affected.
:daisuke, is this bug important enough to require an uplift?

For more information, please visit BugBot documentation.

Flags: needinfo?(daisuke)
Flags: needinfo?(daisuke)

firefox-beta Uplift Approval Request

  • User impact if declined: The way to show the Unified Search Button by keyboard will be inconsistent.
  • Code covered by automated testing: yes
  • Fix verified in Nightly: no
  • Needs manual QE test: no
  • Steps to reproduce for manual QE testing:
  • Risk associated with taking this patch: low
  • Explanation of risk level: The main change in this patch is one line. Also, this affects only the behavior after hiding the popup of Unified Search Button.
  • String changes made/needed: None
  • Is Android affected?: no
Attachment #9518289 - Flags: approval-mozilla-beta?

Reproduced with Firefox 143.0a1 (2024-07-28) on macOS 15.
Verified as fixed with Firefox 145.0a1 (20251006155229) on macOS 14, Windows 10 and Ubuntu 22.

Status: RESOLVED → VERIFIED
Has STR: --- → yes
QA Whiteboard: [search] [qa-triage-done-c145/b144] [qa-ver-needed-c145/b144] → [search] [qa-triage-done-c145/b144] [qa-ver-done-c145/b144]

Comment on attachment 9518289 [details]
Bug 1979826: Set focused element when popuphiding to avoid focusing processing upon popupshowing

As we are in RC week and no more betas left in this cycle, moving request to release for possible dot release ride-along

Attachment #9518289 - Flags: approval-mozilla-beta? → approval-mozilla-release?
Attachment #9518289 - Flags: approval-mozilla-release? → approval-mozilla-release+
QA Contact: dlucaci

Verified as fixed with Firefox 144.0.2 (20251027123126) on macOS 14, Windows 10 and Ubuntu 22.

You need to log in before you can comment on or make changes to this bug.