Landingpage renovation #35

Merged
fnetX merged 72 commits from :McTom234_renovate-landingpage into codeberg-1.17 2022-07-24 23:20:08 +02:00
Member

Fresh design for the landing/about page.
Includes responsive behavior for all display sizes.
Misses some icons and a background-image.

Fresh design for the landing/about page. Includes responsive behavior for all display sizes. ~~Misses some icons and a background-image.~~
McTom234 changed title from WIP: Landingpage renovation to Landingpage renovation 2022-06-19 13:00:19 +02:00
fnetX self-assigned this 2022-06-19 16:48:47 +02:00
Member

should we wait to rebase this pull onto codeberg-1.17 ?

should we wait to rebase this pull onto `codeberg-1.17` ?
McTom234 force-pushed McTom234_renovate-landingpage from e283686bfe to 8950c5212b 2022-06-22 12:27:04 +02:00 Compare
McTom234 changed target branch from codeberg-1.16 to codeberg-1.17 2022-06-22 12:27:47 +02:00
Author
Member

PR is rebased onto codeberg-1.17

PR is rebased onto `codeberg-1.17`
McTom234 force-pushed McTom234_renovate-landingpage from 8950c5212b to 6cbc37a4a6 2022-06-22 13:11:03 +02:00 Compare
Member

What is the name of the mountain you used?

What is the name of the mountain you used?
Owner

What is the name of the mountain you used?

Ask @mray

> What is the name of the mountain you used? Ask @mray
First-time contributor

What is the name of the mountain you used?

"Mount Shasta" CA, USA

https://unsplash.com/photos/3K6ZkYBj2Xo

> What is the name of the mountain you used? "Mount Shasta" CA, USA https://unsplash.com/photos/3K6ZkYBj2Xo
Owner
diff --git a/webpack.config.js b/webpack.config.js
index bc16f18b7..76117c76e 100644
--- a/webpack.config.js
+++ b/webpack.config.js
@@ -54,7 +54,7 @@ export default {
       fileURLToPath(new URL('web_src/less/index.less', import.meta.url)),
     ],
     homepage: [
-      resolve(__dirname, 'web_src/less/homepage.less')
+      fileURLToPath(new URL('web_src/less/homepage.less', import.meta.url)),
     ],
     swagger: [
       fileURLToPath(new URL('web_src/js/standalone/swagger.js', import.meta.url)),

?

~~~diff diff --git a/webpack.config.js b/webpack.config.js index bc16f18b7..76117c76e 100644 --- a/webpack.config.js +++ b/webpack.config.js @@ -54,7 +54,7 @@ export default { fileURLToPath(new URL('web_src/less/index.less', import.meta.url)), ], homepage: [ - resolve(__dirname, 'web_src/less/homepage.less') + fileURLToPath(new URL('web_src/less/homepage.less', import.meta.url)), ], swagger: [ fileURLToPath(new URL('web_src/js/standalone/swagger.js', import.meta.url)), ~~~ ?
@ -25,1 +46,4 @@
</div>
<div class="header-background-image"
style="background-image: url('../public/img/svg/codeberg-landingpage-mountain-background-crop.svg')"
Owner
-				 style="background-image: url('../public/img/svg/codeberg-landingpage-mountain-background-crop.svg')"
+				 style="background-image: url('../assets/img/svg/codeberg-landingpage-mountain-background-crop.svg')"

Please also apply to the other URLs.

~~~diff - style="background-image: url('../public/img/svg/codeberg-landingpage-mountain-background-crop.svg')" + style="background-image: url('../assets/img/svg/codeberg-landingpage-mountain-background-crop.svg')" ~~~ Please also apply to the other URLs.
6543 marked this conversation as resolved
First-time contributor

Are you looking for some feedback on the language/grammar used? I can see some spots where it could be better/minor errors, but don't know if it's placeholders for now or not.

Are you looking for some feedback on the language/grammar used? I can see some spots where it could be better/minor errors, but don't know if it's placeholders for now or not.
Owner

@CapableWeb I just pushed the commits that were intended to fix links and we revisited the texts. Please re-check now, feedback is very welcome.

@CapableWeb I just pushed the commits that were intended to fix links and we revisited the texts. Please re-check now, feedback is very welcome.
@ -26,0 +59,4 @@
<div>
<h3>NON-PROFIT</h3>
<p>
Codeberg is not run by a company, but in the hands of their users via the non-profit organization Codeberg
First-time contributor

but in the hands of their users

Probably want it to be:

but in the hands of its users

> but in the hands of their users Probably want it to be: > but in the hands of its users
fnetX marked this conversation as resolved
First-time contributor

@fnetX seems all/most issues I spotted before already been fixed :) Excited to see a new landing page 🎉

@fnetX seems all/most issues I spotted before already been fixed :) Excited to see a new landing page 🎉
Fixes #20080
The code introduced by #18185 gets the error from response after it was processed by goth.

That is incorrect, as goth (and golang.org/x/oauth) doesn't really care about the error, and it sends a token request with an empty authorization code to the server anyway, which always results in a `oauth2: cannot fetch token: 400 Bad Request` error from goth.
It means that unless the "state" parameter is omitted from the error response (which is required to be present, according to [RFC 6749, Section 4.1.2.1](https://datatracker.ietf.org/doc/html/rfc6749#section-4.1.2.1)) or the page is reloaded (makes the session invalid), a 500 Internal Server Error page will be displayed.
This fixes it by handling the error before the request is passed to goth.
Backport #20127

Store the file uuid(which is returned by Gitea in the upload file response) onto the file object, so it can be used for the remove feature to specify this file.

Fix #20115
- Backport #20142
  - Firefox on Windows will unconditionally show scrollbars when you specify `overflow: scroll`. This is bad behavior, as you don't always need the scrollbar. Changing the scroll value to auto fixes this issue and only shows the scrollbar when necessary.
  - Resolves #20139
6543 approved these changes 2022-07-02 19:12:25 +02:00
6543 left a comment
Member

lgtm from my side :)

through I will wait for the once who are in care of this pull ;)

lgtm from my side :) through I will wait for the once who are in care of this pull ;)
@ -37,0 +87,4 @@
<div class="home-section-about-title">
<p>PROJECTS</p>
<p>USERS</p>
<p>MEMBERS</p>
Owner

For the normal user the meaning of user and member is almost the same. I think it should be specified that it means the amount of members that codeberg e.v. has.

For the normal user the meaning of user and member is almost the same. I think it should be specified that it means the amount of members that codeberg e.v. has.
Owner

e.V. Member?
Backing Members?
Legal Members?

Or show some tooltip on hover, maybe with some ?-icon?

e.V. Member? Backing Members? Legal Members? Or show some tooltip on hover, maybe with some <kbd>?</kbd>-icon?
Owner

e.V. Member?

Indicates it's a member of the non-profit.

Backing Members?

Codeberg is a kickstarter huh?

Legal Members?

Very vague.

> e.V. Member? Indicates it's a member of the non-profit. > Backing Members? Codeberg is a kickstarter huh? > Legal Members? Very vague.
fnetX marked this conversation as resolved
First-time contributor

For reference the design issues regarding the landing page can be found here: https://codeberg.org/Codeberg/Design/issues?q=&type=all&state=open&labels=6013&milestone=0&assignee=0

For reference the design issues regarding the landing page can be found here: https://codeberg.org/Codeberg/Design/issues?q=&type=all&state=open&labels=6013&milestone=0&assignee=0
First-time contributor

This is good to go online in my eyes now.

This is good to go online in my eyes now.
fnetX referenced this pull request from a commit 2022-07-24 23:19:47 +02:00
fnetX merged commit 5f40152a1f into codeberg-1.17 2022-07-24 23:20:08 +02:00
McTom234 deleted branch McTom234_renovate-landingpage 2022-07-24 23:23:07 +02:00
fnetX referenced this pull request from a commit 2023-01-07 18:53:08 +01:00
fnetX referenced this pull request from a commit 2023-01-07 20:01:36 +01:00
fnetX referenced this pull request from a commit 2023-01-08 14:30:25 +01:00
fnetX referenced this pull request from a commit 2023-01-12 11:15:12 +01:00
fnetX referenced this pull request from a commit 2023-01-21 23:12:55 +01:00
fnetX referenced this pull request from a commit 2023-01-31 01:05:28 +01:00
fnetX referenced this pull request from a commit 2023-02-12 15:18:50 +01:00
fnetX referenced this pull request from a commit 2023-02-23 21:50:07 +01:00
fnetX referenced this pull request from a commit 2023-04-23 00:46:42 +02:00
fnetX referenced this pull request from a commit 2023-04-25 16:42:45 +02:00
fnetX referenced this pull request from a commit 2023-04-28 17:50:40 +02:00
fnetX referenced this pull request from a commit 2023-05-03 22:25:58 +02:00
fnetX referenced this pull request from a commit 2023-06-03 03:44:27 +02:00
fnetX referenced this pull request from a commit 2023-06-07 22:33:30 +02:00
fnetX referenced this pull request from a commit 2023-06-23 02:03:04 +02:00
fnetX referenced this pull request from a commit 2023-07-05 11:21:54 +02:00
fnetX referenced this pull request from a commit 2023-07-05 12:07:28 +02:00
fnetX referenced this pull request from a commit 2023-08-03 17:50:22 +02:00
Gusted referenced this pull request from a commit 2023-08-03 19:23:57 +02:00
fnetX referenced this pull request from a commit 2023-08-10 01:36:50 +02:00
fnetX referenced this pull request from a commit 2023-08-21 19:17:23 +02:00
fnetX referenced this pull request from a commit 2023-08-24 20:44:12 +02:00
fnetX referenced this pull request from a commit 2023-12-08 20:37:05 +01:00
fnetX referenced this pull request from a commit 2023-12-12 20:42:54 +01:00
fnetX referenced this pull request from a commit 2023-12-12 20:44:47 +01:00
fnetX referenced this pull request from a commit 2024-04-02 14:49:08 +02:00
fnetX referenced this pull request from a commit 2024-04-03 14:36:03 +02:00
fnetX referenced this pull request from a commit 2024-04-03 17:10:07 +02:00
fnetX referenced this pull request from a commit 2024-04-10 19:20:28 +02:00
Gusted referenced this pull request from a commit 2024-04-11 00:03:18 +02:00
fnetX referenced this pull request from a commit 2024-04-11 00:23:56 +02:00
fnetX referenced this pull request from a commit 2024-04-18 18:12:47 +02:00
fnetX referenced this pull request from a commit 2024-08-12 22:52:19 +02:00
fnetX referenced this pull request from a commit 2024-10-05 01:24:19 +02:00
fnetX referenced this pull request from a commit 2024-10-15 23:39:06 +02:00
fnetX referenced this pull request from a commit 2024-11-21 01:05:42 +01:00
fnetX referenced this pull request from a commit 2025-01-22 22:56:15 +01:00
fnetX referenced this pull request from a commit 2025-02-12 19:22:18 +01:00
Gusted referenced this pull request from a commit 2025-04-02 20:59:28 +02:00
fnetX referenced this pull request from a commit 2025-05-24 14:56:35 +02:00
Gusted referenced this pull request from a commit 2025-10-25 23:35:04 +02:00
Gusted referenced this pull request from a commit 2025-10-26 07:14:57 +01:00
Gusted referenced this pull request from a commit 2025-11-03 03:11:25 +01:00
Gusted referenced this pull request from a commit 2025-11-11 07:18:51 +01:00
Gusted referenced this pull request from a commit 2025-11-21 07:30:22 +01:00
Gusted referenced this pull request from a commit 2025-12-09 01:10:51 +01:00
Gusted referenced this pull request from a commit 2025-12-22 01:49:08 +01:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
8 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Codeberg-Infrastructure/forgejo!35
No description provided.