Only overwrite Codable.swift if it has changed. - #205
Merged
Conversation
darrell-roberts
requested changes
Nov 12, 2024
darrell-roberts
left a comment
darrell-roberts
left a comment
Member
There was a problem hiding this comment.
Couple of changes requested.
seanaye
approved these changes
Nov 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typeshare was always writing Codable.swift when generating multiple files. The issue is that the updated modification date on Codable.swift would trigger Xcode to rebuild the module, even if there were no changes.
This PR now checks the contents of Codable.swift and only overwrites it if the contents need changing.