fix(deps): resolve Dependabot vulnerabilities - #3
Conversation
zhanghanduo
left a comment
There was a problem hiding this comment.
Thanks for putting together the dependency security refresh. I found one blocking compatibility regression and one coverage gap:
-
Blocking: uv.lock upgrades openai from 2.29.0 to 2.54.0, but the current config/bootstrap path can pass a cached empty api_key directly to AsyncOpenAI. The lint-and-smoke job reproduces this in test_benchmark_session_bootstraps_team_runtime: OpenAIError: Missing credentials (1701 passed, 1 failed). Please either make the runtime compatible with the new SDK (for example, normalize an empty key to None and/or reload config when environment values change) or retain a compatible OpenAI version, then rerun the full suite. A regression test for the cached-empty-key -> env-set-later path would be valuable.
-
Non-blocking coverage: the Anthropic 1.0 / httpx2 Bedrock override has no focused test. Please add a unit test that exercises _prepare_request and verifies that Authorization: Bearer is injected with the locked Anthropic transport.
The branch also currently conflicts with main in uv.lock, so the lock should be regenerated after rebasing and CI rerun.
|
Addressed both review findings in fe1946f:
Verification: 1,703 tests passed; Ruff passed; Pyright passed with 0 errors; both import-smoke stages, symbol closure, and lazy-export checks passed. |
Summary
Verification