Conversation
- Add RoborazziTest covering all 9 chart activities (bar, line, pie, horizontal bar, bubble, scatter, candle stick, combined, radar) - Configure Roborazzi plugin with outputDir pointing to src/test/snapshots/ so reference images are tracked in version control - Use w411dp-h891dp-420dpi qualifier (~1080x2340px) to avoid exceeding Android's 100MB hardware canvas bitmap limit - Add verifyRoborazziDebug step to the Check CI job with artifact upload Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Run only :chartLib:test in Check job (avoids double-running app unit tests since verifyRoborazziDebug covers the app) - Remove unused roborazzi-junit-rule dependency (RoborazziRule removed) - Add if-no-files-found: ignore for Roborazzi report artifact (reports dir only exists on test failures) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
LineChartActivity uses CUBIC_BEZIER mode and CombinedChartActivity includes a line dataset. Cubic bezier path rendering involves floating-point math that produces minor sub-pixel differences between macOS (local) and Linux (CI), causing flaky verify failures. A 1% (0.01f) changeThreshold tolerates these platform differences while still catching real visual regressions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.