-
-
Notifications
You must be signed in to change notification settings - Fork 82
Add english locale to case conversions #1295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for catching this. |
mergify bot
added a commit
that referenced
this pull request
Sep 8, 2025
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4.4.0 to 5.0.0. Release notes *Sourced from [actions/setup-node's releases](https://github.com/actions/setup-node/releases).* > v5.0.0 > ------ > > What's Changed > -------------- > > ### Breaking Changes > > * Enhance caching in setup-node with automatic package manager detection by [`@priya-kinthali`](https://github.com/priya-kinthali) in [actions/setup-node#1348](https://redirect.github.com/actions/setup-node/pull/1348) > > This update, introduces automatic caching when a valid `packageManager` field is present in your `package.json`. This aims to improve workflow performance and make dependency management more seamless. To disable this automatic caching, > set `package-manager-cache: false` > > ``` > steps: > - uses: actions/checkout@v5 > - uses: actions/setup-node@v5 > with: > package-manager-cache: false > ``` > > * Upgrade action to use node24 by [`@salmanmkc`](https://github.com/salmanmkc) in [actions/setup-node#1325](https://redirect.github.com/actions/setup-node/pull/1325) > > Make sure your runner is on version v2.327.1 or later to ensure compatibility with this release. [See Release Notes](https://github.com/actions/runner/releases/tag/v2.327.1) > > ### Dependency Upgrades > > * Upgrade `@octokit/request-error` and `@actions/github` by [`@dependabot`](https://github.com/dependabot)[bot] in [actions/setup-node#1227](https://redirect.github.com/actions/setup-node/pull/1227) > * Upgrade uuid from 9.0.1 to 11.1.0 by [`@dependabot`](https://github.com/dependabot)[bot] in [actions/setup-node#1273](https://redirect.github.com/actions/setup-node/pull/1273) > * Upgrade undici from 5.28.5 to 5.29.0 by [`@dependabot`](https://github.com/dependabot)[bot] in [actions/setup-node#1295](https://redirect.github.com/actions/setup-node/pull/1295) > * Upgrade form-data to bring in fix for critical vulnerability by [`@gowridurgad`](https://github.com/gowridurgad) in [actions/setup-node#1332](https://redirect.github.com/actions/setup-node/pull/1332) > * Upgrade actions/checkout from 4 to 5 by [`@dependabot`](https://github.com/dependabot)[bot] in [actions/setup-node#1345](https://redirect.github.com/actions/setup-node/pull/1345) > > New Contributors > ---------------- > > * [`@priya-kinthali`](https://github.com/priya-kinthali) made their first contribution in [actions/setup-node#1348](https://redirect.github.com/actions/setup-node/pull/1348) > * [`@salmanmkc`](https://github.com/salmanmkc) made their first contribution in [actions/setup-node#1325](https://redirect.github.com/actions/setup-node/pull/1325) > > **Full Changelog**: <actions/setup-node@v4...v5.0.0> Commits * [`a0853c2`](actions/setup-node@a0853c2) Bump actions/checkout from 4 to 5 ([#1345](https://redirect.github.com/actions/setup-node/issues/1345)) * [`b7234cc`](actions/setup-node@b7234cc) Upgrade action to use node24 ([#1325](https://redirect.github.com/actions/setup-node/issues/1325)) * [`d7a1131`](actions/setup-node@d7a1131) Enhance caching in setup-node with automatic package manager detection ([#1348](https://redirect.github.com/actions/setup-node/issues/1348)) * [`5e2628c`](actions/setup-node@5e2628c) Bumps form-data ([#1332](https://redirect.github.com/actions/setup-node/issues/1332)) * [`65becef`](actions/setup-node@65becef) Bump undici from 5.28.5 to 5.29.0 ([#1295](https://redirect.github.com/actions/setup-node/issues/1295)) * [`7e24a65`](actions/setup-node@7e24a65) Bump uuid from 9.0.1 to 11.1.0 ([#1273](https://redirect.github.com/actions/setup-node/issues/1273)) * [`08f58d1`](actions/setup-node@08f58d1) Bump `@octokit/request-error` and `@actions/github` ([#1227](https://redirect.github.com/actions/setup-node/issues/1227)) * See full diff in [compare view](actions/setup-node@49933ea...a0853c2) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
mergify bot
added a commit
that referenced
this pull request
Dec 1, 2025
… to 2.20.1 [skip ci] Bumps [org.codehaus.mojo:versions-maven-plugin](https://github.com/mojohaus/versions) from 2.19.1 to 2.20.1. Release notes *Sourced from [org.codehaus.mojo:versions-maven-plugin's releases](https://github.com/mojohaus/versions/releases).* > 2.20.1 > ------ > > 🐛 Bug Fixes > ----------- > > * Fixed [#1313](https://redirect.github.com/mojohaus/versions/issues/1313): Do not show existing version as update ([#1315](https://redirect.github.com/mojohaus/versions/pull/1315)) [`@andrzejj0`](https://github.com/andrzejj0) > > 2.20.0 > ------ > > 🚀 New features and improvements > ------------------------------- > > * Allow filtering out pre releases in use-latest-versions ([#1283](https://redirect.github.com/mojohaus/versions/pull/1283)) [`@Artur`](https://github.com/Artur)- > * [#979](https://redirect.github.com/mojohaus/versions/issues/979): Output file is not overwritten by default ([#1279](https://redirect.github.com/mojohaus/versions/pull/1279)) [`@andrzejj0`](https://github.com/andrzejj0) > > 🐛 Bug Fixes > ----------- > > * Fixed a problem with dependency management filtering in the logged results ([#1298](https://redirect.github.com/mojohaus/versions/pull/1298)) [`@andrzejj0`](https://github.com/andrzejj0) > * Fixes [#1295](https://redirect.github.com/mojohaus/versions/issues/1295): getAllUpdates(boolean) should respect currentVersionRange ([#1297](https://redirect.github.com/mojohaus/versions/pull/1297)) [`@andrzejj0`](https://github.com/andrzejj0) > * Fixed [#1287](https://redirect.github.com/mojohaus/versions/issues/1287) - Versionless dependencies in dependencyManagement accepted by maven, but not bij resolve-ranges ([#1288](https://redirect.github.com/mojohaus/versions/pull/1288)) [`@maroschutte`](https://github.com/maroschutte) > * Artifact comparison should use semantic version comparison. ([#1281](https://redirect.github.com/mojohaus/versions/pull/1281)) [`@andrzejj0`](https://github.com/andrzejj0) > * Resolves [#1150](https://redirect.github.com/mojohaus/versions/issues/1150): Resolve multiple level properties (properties resolving to properties) ([#1276](https://redirect.github.com/mojohaus/versions/pull/1276)) [`@andrzejj0`](https://github.com/andrzejj0) > > 📝 Documentation updates > ----------------------- > > * Add more examples of ignoredVersions config parameter ([#1296](https://redirect.github.com/mojohaus/versions/pull/1296)) [`@mikkoi`](https://github.com/mikkoi) > * Fix broken href link in site ([#1294](https://redirect.github.com/mojohaus/versions/pull/1294)) [`@mikkoi`](https://github.com/mikkoi) > * Added remaining javadoc comments. ([#1293](https://redirect.github.com/mojohaus/versions/pull/1293)) [`@andrzejj0`](https://github.com/andrzejj0) > * Getting rid of javadoc warnings ([#1292](https://redirect.github.com/mojohaus/versions/pull/1292)) [`@andrzejj0`](https://github.com/andrzejj0) > > 👻 Maintenance > ------------- > > * ResolverAdapter: a thin adapter over Resolver ([#1301](https://redirect.github.com/mojohaus/versions/pull/1301)) [`@andrzejj0`](https://github.com/andrzejj0) > * Fixed a problem with dependency management filtering in the logged results ([#1298](https://redirect.github.com/mojohaus/versions/pull/1298)) [`@andrzejj0`](https://github.com/andrzejj0) > * Fix broken href link in site ([#1294](https://redirect.github.com/mojohaus/versions/pull/1294)) [`@mikkoi`](https://github.com/mikkoi) > * Added remaining javadoc comments. ([#1293](https://redirect.github.com/mojohaus/versions/pull/1293)) [`@andrzejj0`](https://github.com/andrzejj0) > * Getting rid of javadoc warnings ([#1292](https://redirect.github.com/mojohaus/versions/pull/1292)) [`@andrzejj0`](https://github.com/andrzejj0) > * Removed a redundant integration test ([#1280](https://redirect.github.com/mojohaus/versions/pull/1280)) [`@andrzejj0`](https://github.com/andrzejj0) > > 📦 Dependency updates > -------------------- > > * Bump org.apache.commons:commons-lang3 from 3.19.0 to 3.20.0 ([#1312](https://redirect.github.com/mojohaus/versions/pull/1312)) @[dependabot[bot]](https://github.com/apps/dependabot) > * Bump byteBuddyVersion from 1.18.0 to 1.18.1 ([#1311](https://redirect.github.com/mojohaus/versions/pull/1311)) @[dependabot[bot]](https://github.com/apps/dependabot) > * Bump org.codehaus.plexus:plexus-archiver from 4.10.3 to 4.10.4 ([#1307](https://redirect.github.com/mojohaus/versions/pull/1307)) @[dependabot[bot]](https://github.com/apps/dependabot) > * Bump byteBuddyVersion from 1.17.7 to 1.18.0 ([#1309](https://redirect.github.com/mojohaus/versions/pull/1309)) @[dependabot[bot]](https://github.com/apps/dependabot) > * Bump commons-codec:commons-codec from 1.19.0 to 1.20.0 ([#1303](https://redirect.github.com/mojohaus/versions/pull/1303)) @[dependabot[bot]](https://github.com/apps/dependabot) > * Bump commons-io:commons-io from 2.20.0 to 2.21.0 ([#1305](https://redirect.github.com/mojohaus/versions/pull/1305)) @[dependabot[bot]](https://github.com/apps/dependabot) > * Bump org.codehaus.plexus:plexus-i18n from 1.0.0 to 1.1.0 ([#1306](https://redirect.github.com/mojohaus/versions/pull/1306)) @[dependabot[bot]](https://github.com/apps/dependabot) > * Bump org.codehaus.plexus:plexus-interactivity-api from 1.4 to 1.5.1 ([#1308](https://redirect.github.com/mojohaus/versions/pull/1308)) @[dependabot[bot]](https://github.com/apps/dependabot) > * Bump org.apache.maven.plugin-testing:maven-plugin-testing-harness from 3.3.0 to 3.4.0 ([#1302](https://redirect.github.com/mojohaus/versions/pull/1302)) @[dependabot[bot]](https://github.com/apps/dependabot) > * Bump org.codehaus.plexus:plexus-archiver from 4.10.2 to 4.10.3 ([#1290](https://redirect.github.com/mojohaus/versions/pull/1290)) @[dependabot[bot]](https://github.com/apps/dependabot) > * Bump org.codehaus.mojo:mojo-parent from 93 to 94 ([#1285](https://redirect.github.com/mojohaus/versions/pull/1285)) @[dependabot[bot]](https://github.com/apps/dependabot) ... (truncated) Commits * [`b296a4f`](mojohaus/versions@b296a4f) [maven-release-plugin] prepare release 2.20.1 * [`b243939`](mojohaus/versions@b243939) Fixed [#1313](https://redirect.github.com/mojohaus/versions/issues/1313): Do not show existing version as update ([#1315](https://redirect.github.com/mojohaus/versions/issues/1315)) * [`773d0f3`](mojohaus/versions@773d0f3) [maven-release-plugin] prepare for next development iteration * [`2467d99`](mojohaus/versions@2467d99) [maven-release-plugin] prepare release 2.20.0 * [`4c240e7`](mojohaus/versions@4c240e7) Bump org.apache.commons:commons-lang3 from 3.19.0 to 3.20.0 * [`6d64537`](mojohaus/versions@6d64537) Bump byteBuddyVersion from 1.18.0 to 1.18.1 * [`7736ca6`](mojohaus/versions@7736ca6) Bump org.codehaus.plexus:plexus-archiver from 4.10.3 to 4.10.4 * [`37a5330`](mojohaus/versions@37a5330) Bump byteBuddyVersion from 1.17.7 to 1.18.0 * [`edeb5e7`](mojohaus/versions@edeb5e7) Bump commons-codec:commons-codec from 1.19.0 to 1.20.0 * [`88874e0`](mojohaus/versions@88874e0) Bump commons-io:commons-io from 2.20.0 to 2.21.0 * Additional commits viewable in [compare view](mojohaus/versions@2.19.1...2.20.1) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
These changes add
LOCALE.Englishto all calls oftoLowerCaseandtoUpperCase. For all strings related to commands,keywords or configuration, english localization is obvious, but it seems even for user/data stringsLOCALE.Englishseems to be fine (see here).Motivation
This is an internationalization best practice in
spotbugs.Additional Notes
The change in
.pre-commit-config.yamlwas necessary to be able to commit.Checklist
mvn clean packagecommand