This repository was archived by the owner on Feb 6, 2026. It is now read-only.
Fix live test deployment and code issues - #723
Merged
Merged
Conversation
hallipr
requested review from
JonathanCrd,
KarishmaGhiya,
g2vinay,
jongio,
joshfree,
wbreza and
xiangyan99
July 24, 2025 20:11
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes deployment and testing issues by ensuring the monitor tests use the correct storage account name and removing an invalid bicep property value. The changes address infrastructure deployment failures and test reliability.
- Updated monitor tests to use the correct storage account naming convention
- Commented out invalid workbook resource with unsupported 'user' kind
- Added storage account role assignment for test application access
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/Areas/Monitor/LiveTests/MonitorCommandTests.cs | Updated storage account name references to use the correct naming convention with "mon" suffix |
| infra/services/workbooks.bicep | Commented out user workbook resource that uses invalid 'user' kind property |
| infra/services/monitor.bicep | Added blob contributor role assignment for test application to access storage account |
weshaggard
approved these changes
Jul 24, 2025
weshaggard
approved these changes
Jul 24, 2025
vcolin7
reviewed
Jul 24, 2025
vcolin7
approved these changes
Jul 24, 2025
github-project-automation
Bot
moved this from Untriaged
to Done
in Azure MCP Server (OLD)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Monitor wasn't testing with the storage account it deployed
Workbooks was using an invalid bicep property value
Pre-merge Checklist
CHANGELOG.mdfor product changes (features, bug fixes, UI/UX, updated dependencies).\eng\common\spelling\Invoke-Cspell.ps1README.mddocumentation/docs/azmcp-commands.md/e2eTests/e2eTestPrompts.mdcrypto mining, spam, data exfiltration, etc.)/azp run azure - mcpto run Live Test Pipeline