Skip to content
This repository was archived by the owner on Feb 6, 2026. It is now read-only.

Add appconfig unit tests - #749

Merged
chidozieononiwu merged 2 commits into
Azure:mainfrom
chidozieononiwu:appconfig-unit-two
Jul 30, 2025
Merged

Add appconfig unit tests#749
chidozieononiwu merged 2 commits into
Azure:mainfrom
chidozieononiwu:appconfig-unit-two

Conversation

@chidozieononiwu

Copy link
Copy Markdown
Member

What does this PR do?

Replaces #396 after repo restructuring

GitHub issue number?

https://github.com/Azure/azure-mcp-pr/issues/296

Copilot AI review requested due to automatic review settings July 25, 2025 23:07
@chidozieononiwu
chidozieononiwu requested a review from a team as a code owner July 25, 2025 23:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive unit tests for the Azure App Configuration MCP area, providing test coverage for key-value operations and account management functionality.

  • Adds unit tests for all key-value commands (set, get, list, delete, lock, unlock)
  • Adds unit tests for account listing command
  • Includes proper test project setup with required dependencies

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
AzureMcp.AppConfig.UnitTests.csproj New test project file with NSubstitute and xUnit dependencies
KeyValue/*CommandTests.cs Unit tests for all key-value commands testing happy path, error cases, and parameter validation
Account/AccountListCommandTests.cs Unit tests for account listing command with various scenarios
Models/*.cs Internal record types added to support test result verification
AzureMcp.sln Solution file updated to include new test project
AccessPolicyListCommandTests.cs Removed unused import statement
Comment thread AzureMcp.sln Outdated
Comment thread areas/appconfig/src/AzureMcp.AppConfig/Models/AppConfigurationAccount.cs Outdated
Comment thread areas/appconfig/src/AzureMcp.AppConfig/Models/KeyValueSetting.cs Outdated
@github-project-automation github-project-automation Bot moved this from Untriaged to In Progress in Azure MCP Server (OLD) Jul 29, 2025
@chidozieononiwu
chidozieononiwu merged commit fff785c into Azure:main Jul 30, 2025
57 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Azure MCP Server (OLD) Jul 30, 2025
KarishmaGhiya pushed a commit to KarishmaGhiya/azure-mcp that referenced this pull request Jul 31, 2025
* Add appconfig-unit tests

* Resolve various issues raised in PR
anannya03 pushed a commit that referenced this pull request Aug 6, 2025
* Add appconfig-unit tests

* Resolve various issues raised in PR
chidozieononiwu added a commit to chidozieononiwu/azure-mcp that referenced this pull request Aug 18, 2025
* Add appconfig-unit tests

* Resolve various issues raised in PR
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants