Clear Sentry breadcrumbs at the end of every request

[hugochinchilla]

We are seeing breadcrumbs from previous requests on our traces in Sentry, this makes it less useful for debugging and also causes the memory usage to increase between requests.

[Baldinof]

Hi, thank you for using this bundle :)

The listener you modified is called only on worker stop (process exit) and not on every request.

A good place to fix this is in the middleware, where a configureScope() is already called: https://github.com/Baldinof/roadrunner-bundle/blob/master/src/Http/Middleware/SentryMiddleware.php#L65

[Baldinof]

Also, I see that Scope has a clear() method, maybe it's a good idea to call this to clear all contextual data on the new request?

[hugochinchilla]

@Baldinof you are right, i have changed the code to use this method instead.

[Baldinof]

I don't see the new diff, did you pushed it?

[hugochinchilla]

Sorry, it's pushed now

[Baldinof]

👍

Can you call clear() in the SentryMiddlware instead of on the WorkerStopEvent?

[hugochinchilla]

I moved the code to the middleware and added a test case.

[Baldinof]

Perfect!

Can you run composer cs:fix to fix the failing CI job?

[hugochinchilla]

Done!

[Baldinof]

Thank you :)

[Baldinof]

I released 1.3.2 with your fix.

[hugochinchilla]

Thank you very much!!