Clear search when a new note is created

[Pudge601]

This ensures that the newly created note is visible and selected in the note list.

Fixes #2241

[ZeroX-DG]

You code will not focus the correct note if there is one note that matched in the search box.

[Pudge601]

Hmm... that's true.

The more I'm looking into this issue, the more confused I'm getting. I'm starting to think that the root issue is that the code for jumping to a note by hash (using the list:jump event) doesn't work if the note is not visible in the note list.

That event gets fired when a new note is created (hence this issue), and also when clicking a link to a note from another note (browser/components/MarkdownPreview.js:826). I've tested and found the same issue when clicking a note link; if there is a search active which the linked note does not match, then it will not jump to the linked note.

However, just to add to my confusion, it is possible to jump to a linked note which isn't in the current note list when looking at Starred notes, or notes within a particular Storage folder - in this case, the note is shown in the preview, but doesn't appear in the notes list on the left! I have now idea how this behaviour works, but I'm tempted to say that it is a bug in itself (or at least unintended behaviour), since it leads to a very weird scenario where the note which is in the preview is not the focused note in the note list, and in fact doesn't even appear in the note list.

This has led me to thinking that perhaps it should be switching to the /home route whenever we jump to a note by its hash. This provides consistent behaviour for all of these scenarios;

• Creating a note with search active
• Jumping to a linked note with search active
• Jumping to a linked note while looking at Starred notes
• Jumping to a linked note while looking at a Storage folder

[Pudge601]

I've changed my fix in this PR to switch to the '/home' route when jumping to a note by hash. This should solve all of the issues described in my last comment in a consistent manner.

[ZeroX-DG]

Is it because of me or the old bug is still there?

[ZeroX-DG]

@Pudge601 What's the status of this?
EDIT Sorry for bothering you. Somehow it works fine now.

[ZeroX-DG]

LGTM 🎉

[ZeroX-DG]

Also fixed this: #2647

[Pudge601]

Sorry, I completely missed your comment back in October about it not working :S not sure why it wouldn't have worked when you tested it, but glad it's all sorted now 👍