Fix issue2534 #2658

gregueiras · 2018-11-29T14:24:50Z

Description

Users can now schedule a theme to be applied

In this example, from 07:20 to 17:50 the theme to be used is Monokai, otherwise the Default theme is used

Issue fixed

Issue #2534 Scheduled themes or auto day/night mode

Type of changes

🔘 Bug fix (Change that fixed an issue)
⚪ Breaking change (Change that can cause existing functionality to change)
⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
🔘 Feature (Change that adds new functionality)
⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

🔘 My code follows the project code style
⚪ I have written test for my code and it has been tested
⚪ All existing tests have been passed
🔘 I have attached a screenshot/video to visualize my change if possible

Note: I couldn't run the tests

ZeroX-DG · 2018-11-29T14:29:01Z

Wow @gregueiras It looks amazing!

gregueiras · 2018-11-29T14:43:50Z

@ZeroX-DG Thank you 😄

I submitted an extra file, it was not necessary

ZeroX-DG · 2020-02-24T22:32:11Z

@gregueiras can you resolve all the conflicts?

…xIssue2534

gregueiras · 2020-02-25T03:32:33Z

@gregueiras can you resolve all the conflicts?

I've resolved all the conflicts and changed the scheduled theme dropdown options to be the same as the default theme one.

ZeroX-DG · 2020-02-25T20:28:52Z

browser/main/modals/PreferencesModal/UiTab.js

  }

+  /**
+   * Gets the total number of minutes and returns a string in the HH:MM format


Can you remove this comment since it's not relevant anymore?

I've removed that comment

ZeroX-DG · 2020-03-03T02:20:06Z

browser/main/modals/PreferencesModal/UiTab.js

+    if (rangeSlider && rangeBullet) {
+      const bulletPosition = rangeSlider.value / rangeSlider.max
+      rangeBullet.style.left =
+        bulletPosition * 574 + 6 * (1 - bulletPosition) + 'px'


Can you explain to me where the value 574 come from?

We thought that we needed to set the slider position, but I tried removing it and it is working as expected, so I've removed the handleSlider function and we can just use the handleUIChange

ZeroX-DG

Everything works fine but somehow the theme doesn't automatically change when the time is out of the range. I'm currently pretty busy so I can't investigate this. Can you help me investigate it? probably a problem that cause the interval to stop working correctly

gregueiras · 2020-03-10T15:46:13Z

browser/main/lib/ThemeManager.js

+  const isBetweenStartAndEnd = minutes >= start && minutes < end
+  const isBetweenEndAndStart = minutes >= start || minutes < end


I've fixed the problem. It was just the way I was comparing the dates. If you scheduled the change to happen at 15:30, it would change only at 15:31.

ZeroX-DG · 2020-03-14T13:07:39Z

@gregueiras it's still not working for me. I'm not quite sure what is causing it because at first the setInterval doesn't work so I removed this.refreshTheme= and it start running but it still doesn't change the theme. I was on setting page the theme didn't change, not sure if it change on main page.

gregueiras · 2020-03-24T03:20:42Z

Hey, sorry about the delay.

I couldn't reproduce your problem...
I thought it could be some bug regarding timezone, but even after changing it, it's still working

Do you have any other idea?

ZeroX-DG · 2020-03-26T22:29:42Z

@gregueiras The problem that I'm having is the incorrect theme from config. I added this line in your refresh theme loop.

And this is what been logging to the terminal

Do you have any idea for what is causing this issue?

gregueiras · 2020-03-27T00:17:09Z

I believe I've fixed it!

Previously, I was changing the instance returned from ConfigManager, but wasn't really setting it anywhere. I've changed ThemeManager to save the changes (using ConfigManager's set), so it should work correctly now.

Let me know if it's still not working for you!

ZeroX-DG

Very cool, works perfectly now. Thank you for this PR 👍

gregueiras added 12 commits November 26, 2018 20:11

Multi tab WIP

aa38b1f

Values are now saved

1d21bb1

Format

e137424

Border added

1419c71

Scheduled Theme default configuration

8be0ea6

ThemeManager Created

f38fef2

Fixed checkbox

0f8c627

Interface Improved

36b97fc

Fixed default theme thumb background

3366297

Inverted thumb order

ceed178

Removed colons and semi colons

8b54f5a

Code Style Improvements

cd53a65

ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Nov 29, 2018

gregueiras added 3 commits December 12, 2018 11:37

Delete Slider.styl

7034e7b

I submitted an extra file, it was not necessary

Unit tests added

a19ff67

Merge branch 'master' into fixIssue2534

b91a76b

gregueiras mentioned this pull request Nov 22, 2019

Scroll Bars can now be hidden #2713

Merged

Merge branch 'master' of https://github.com/BoostIO/Boostnote into fi…

d4123ee

…xIssue2534

Fix Lint Errors

9c3f34f

ZeroX-DG requested changes Mar 3, 2020

View reviewed changes

gregueiras added 2 commits March 5, 2020 16:07

Remove comment

8a6df8b

Remove handleSlider

38ed5b8

gregueiras requested a review from ZeroX-DG March 5, 2020 16:40

ZeroX-DG reviewed Mar 7, 2020

View reviewed changes

ZeroX-DG added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Mar 7, 2020

Fix scheduled theme change timing

48c8164

gregueiras commented Mar 10, 2020

View reviewed changes

gregueiras added 2 commits March 27, 2020 01:42

Fix Saving Configuration Bug

e1c95fb

Merge branch 'master' into fixIssue2534

4915c54

ZeroX-DG approved these changes Mar 31, 2020

View reviewed changes

ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Mar 31, 2020

Rokt33r merged commit 0d797ce into BoostIO:master Apr 6, 2020

Rokt33r added this to the v0.15.3 milestone Apr 6, 2020

gregueiras deleted the fixIssue2534 branch April 6, 2020 10:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fix issue2534 #2658

Fix issue2534 #2658

Uh oh!

gregueiras commented Nov 29, 2018

ZeroX-DG commented Nov 29, 2018

gregueiras commented Nov 29, 2018

ZeroX-DG commented Feb 24, 2020

gregueiras commented Feb 25, 2020

ZeroX-DG Feb 25, 2020

gregueiras Mar 5, 2020

ZeroX-DG Mar 3, 2020

gregueiras Mar 5, 2020

ZeroX-DG left a comment

gregueiras Mar 10, 2020

ZeroX-DG commented Mar 14, 2020

gregueiras commented Mar 24, 2020 •

edited

Loading

ZeroX-DG commented Mar 26, 2020

gregueiras commented Mar 27, 2020 •

edited

Loading

ZeroX-DG left a comment

Labels

3 participants

		const isBetweenStartAndEnd = minutes >= start && minutes < end
		const isBetweenEndAndStart = minutes >= start \|\| minutes < end

Uh oh!

Fix issue2534 #2658

Fix issue2534 #2658

Uh oh!

Conversation

gregueiras commented Nov 29, 2018

Description

Issue fixed

Type of changes

Checklist:

ZeroX-DG commented Nov 29, 2018

gregueiras commented Nov 29, 2018

ZeroX-DG commented Feb 24, 2020

gregueiras commented Feb 25, 2020

ZeroX-DG Feb 25, 2020

Choose a reason for hiding this comment

gregueiras Mar 5, 2020

Choose a reason for hiding this comment

ZeroX-DG Mar 3, 2020

Choose a reason for hiding this comment

gregueiras Mar 5, 2020

Choose a reason for hiding this comment

ZeroX-DG left a comment

Choose a reason for hiding this comment

gregueiras Mar 10, 2020

Choose a reason for hiding this comment

ZeroX-DG commented Mar 14, 2020

gregueiras commented Mar 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ZeroX-DG commented Mar 26, 2020

gregueiras commented Mar 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ZeroX-DG left a comment

Choose a reason for hiding this comment

Labels

3 participants

gregueiras commented Mar 24, 2020 •

edited

Loading

gregueiras commented Mar 27, 2020 •

edited

Loading